Fix SliceUpdate JVPs with one traced input - #4200
Open
PhysicistJohn wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
SliceUpdate::jvpcurrently rejects transforms when only the source or update input is traced. Initialize the absent tangent with zeros so assignment and sum slice updates support source-only and update-only JVPs while preserving the existing two-input behavior. Product, minimum, and maximum JVPs remain unsupported.The focused regression passes 4/4 assertions. The full native suite passes 249/249 tests with 3,346 assertions.
Checklist
pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes