Preserve components in complex-like conversions - #4199
Closed
PhysicistJohn wants to merge 1 commit into
Closed
Conversation
Member
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Complex-like inputs that also expose a scalar conversion currently select the scalar constructor, replacing their real component with the scalar value and dropping the imaginary component. Construct those inputs from
real()andimag()instead, keep scalar and complex-like constructor paths mutually exclusive, and reject complex-like inputs whose components cannot be converted. Existing conversion traits and wrapper layout remain unchanged.The focused regression passes 12/12 assertions. The full native suite passes 249/249 tests with 3,354 assertions, and CTest passes 250/250.
Checklist
pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes