Refactor CPU ScatterAxis and MaskedScatter dtype dispatch - #4176
Merged
zcbenz merged 2 commits intoAug 11, 2026
Conversation
Member
|
Would you mind updating all the dispatch code in the file in one pull request? Our CI is throttled to handle many pull requests. |
Contributor
Author
|
Thanks, Cheng — agreed. I folded the remaining |
zcbenz
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the remaining exhaustive payload dtype switches in CPU
ScatterAxisand
MaskedScatterwith the existingdispatch_all_typeshelper. This keepsthe restricted integer index dispatch, reduction mode selection, broadcasting,
source traversal, and diagnostics unchanged while removing 83 net lines.
Testing
-Werrorpython/tests/test_ops.py(153/153 tests)vmapand autograd coverage for both operationsclang-formatandgit diff --check