fix(installer): vendor Chinese/Korean .isl (not in released ISCC) - #38
Conversation
The v0.x release build proved the official-reference approach wrong: ISCC 6.7.1 on the runner has Japanese/Russian but NOT ChineseSimplified.isl (Chinese isn't in any released 6.7.x — only in issrc main), so the compile aborted with 'Couldn't open include file ...ChineseSimplified.isl'. Korean is in 6.7.1 but is vendored too so neither depends on the runner's installed languages. Both .isl are the community 6.5.0+ translations (a subset of 6.7.x messages → unknown-message-safe; missing newer messages fall back to English), UTF-8 BOM, referenced via installer/i18n/. EN/JA/RU stay on Inno's bundled files.
|
Warning Review limit reached
More reviews will be available in 15 minutes and 3 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Fixes the broken installer build on master. After #29 merged, the release build failed:
The official-
.islapproach was wrong (I was; CodeRabbit was right): ChineseSimplified.isl isn't in any released ISCC — it's only in issrcmain, not in the 6.7.0–6.7.3 tags. Korean is in 6.7.1, but I vendor it too so neither depends on the runner's installed languages..islare the community 6.5.0+ translations (a subset of 6.7.x's message set → no unknown-message errors; any newer messages fall back to English), UTF-8 BOM, underinstaller/i18n/.✅ Verified: a
release.ymldispatch on this branch built the installer green —Build installer (Inno Setup): success, artifact uploaded.Note: unrelated latent bug —
workflow_dispatchon a branch whose name contains/breaks the "Build portable zip" step (the version string gets a slash). Real tag releases (vX.Y.Z) are unaffected; can sanitize separately.