Conversation
- voice_visualizer.py and picker_cli.py: no references anywhere in src, tests, scripts or CI - .serena/: a local tool's project state, not part of the product - scripts/deploy_docs.sh: docs.yml deploys the site; the script was unreferenced - tests/promptfoo/: never run; the evals plan covers prompt regressions differently - tests/test_architecture.py: the UI launcher (launch.py, ports.py, server_cmd.py) prints to the terminal before the UI runtime exists, so it is allowlisted with a reason; the rule had been failing locally on main for that.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes files nothing references (checked with fixed-string search across src, tests, scripts, CI and pyproject):
src/localcode/tui/widgets/voice_visualizer.py,src/localcode/ui/picker_cli.py.serena/(a local tool's project state)scripts/deploy_docs.sh(docs.yml deploys the site)tests/promptfoo/(never run; two stale comments updated)Also allowlists the UI launcher modules in the bare-print architecture rule with a stated reason: they print to the terminal before the UI runtime exists. That rule had been failing locally on main.
Not touched here, pre-existing on main:
tests/test_toolkit.py::TestMCPTransportConfig::test_http_config_builds_http_clientfails because the installedmcplibrary'sstreamable_http_client()no longer acceptsheaders; that is a real integration bug to look at separately.