0.4.7: a gate's instruction restarts the loop breaker; stops say why - #85
Merged
Merged
Conversation
…p says why The model was stopped 9 s after the placeholder gate sent it back to fix a line, because the no-progress counter still ran from a nudge 48 minutes earlier. Every gate send-back (open todo, placeholder, build errors) now restarts the budget. When the breaker does stop a session it shows a toast with the round count and files changed instead of a bare 'Interrupted'. (cherry picked from commit 24e3d5c)
test_completed_download_flips_to_done failed on CI with progress_pct 6 after status 'done': a progress line from a worker flushing its last output (or a stale worker for the same key) landed after completion and moved the entry backwards. Terminal entries are now immutable to progress updates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plateau breaker kept its no-progress count running across gate send-backs, so after the placeholder gate (or the todo gate, or the build-errors gate) told the model to do new work, the breaker could stop the session seconds later while it was reading the file it had just been told to fix. Seen live three times today. Every gate send-back now calls
plateau.freshInstruction(). When the breaker does stop a session it shows a toast with the round count and files changed. Plugin-only; no binary change. Unit test added; the 4 remaining bun failures are the known pre-existing ones.