Conversation
- Add i18n module (i18n.cc/h) with kChineseStrings translation table - Add Noto Sans SC Regular/Bold fonts as Chinese fallback (Roboto lacks CJK glyphs) - Add apply_i18n helper scripts for string extraction
- Wrap all UI strings with Tr() so they translate to Chinese - Complete kChineseStrings table across all screens and editors - Add ChipSelector tag localization (All/Recent/Starred) - Fix format-security warnings from non-literal Text() calls - Localize remaining hardcoded strings (Selection weight, Cancel, TreeNode labels, TextFmt templates)
- Wrap all InputFloat/InputInt/InputBool WithLabelAsId labels with Tr() - Localize BeginMenu items (Add to, Advanced) - Localize stats table row labels (Current/High score/Average) - Add missing translations for Fast, Slow, Start speed percent
- Wrap HelpMarker/HelpTooltip multiline help text with Tr() - Localize input control labels (WithLabelAsId) across editors - Localize BeginMenu items and stats table row labels - Add missing translation for target acceleration help text - Add check_i18n_complete.py to verify all Tr() calls have translations
15 keys were defined twice with identical or conflicting translations. Keep the effective (last) entry for each key; the removed entries were dead overridden lookups in the unordered_map.
- bundle_ui.cc: translate Copy/Add button in bundle popup - quick_settings_screen.cc: translate scroll-to-adjust tooltips - times.cc: translate relative time strings (years/months/weeks/days/hours/minutes ago, Just now) - i18n.cc: add missing Scroll to adjust keys
- Route InputFloat/InputInt/InputBool/ReadonlyLabeledFloat label rendering through Tr() - Wrap remaining hardcoded English labels (multipliers, variation dialog, profile list) in Tr() - Add 'angle' translation key - Extend check_i18n_complete.py to detect translatable labels passed without Tr()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.