Recover the picture-spike measurements that never reached main - #81
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
picture-spikebranch never merged, but most of what it measured on 2026-09-12 already reachedmainsome other way, through PR #73's memory pool fix. This pulls out the small remainder that did not: findings that are still true and still useful, but sitting only on a branch nobody was going to look at again.docs/protocol-notes.md: settles one of the "three questions left open" after the first picture spike, how a picture is listed in the memory configuration (an ordinary eleven-character entry, typeD).docs/protocol-notes.md: explains why a picture's own data isrows * columns / 2bytes rather thanrows * columns, a pixel takes four bits, packed two to a byte, which also confirms the 13-byte overhead nearby is real rather than a rounding artifact.docs/protocol-notes.mdandreaderboard/protocol/frames.py: corrects an overstated claim. Both currently say a read-back of the first file in a memory configuration "will therefore never match what was sent." Measured on 2026-09-12, that is only true once the sign has started playing a run sequence; a read taken right after configuring shows the plan as sent.Test plan
pytestruff check .mypy readerboard