MIST-221032 update openAPI schema - #73
Kevin-DeJong wants to merge 5 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Mist OpenAPI specification to version 2609.1.0 with new APIs, schemas, generated artifacts, and release documentation.
Changes:
- Adds security-zone, SCEP event search, flow-capture, and map-stack APIs.
- Expands inventory, spectrum, multicast, NAC, and related schemas.
- Refreshes OpenAPI, Postman environment, and changelog artifacts.
Reviewed changes
Copilot reviewed 5 out of 8 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Summary |
|---|---|
workdir/openapi.yaml |
Source schema updates. Findings include missing generated Postman operations (moderate, 3 votes), an incompatible spectrum-analysis requirement (moderate, 3 votes), removal of enabled compatibility (critical, 2 votes), incomplete flow-capture WebSocket documentation (nit, 2 votes), and removal of map field aliases (critical, 1 vote). |
tmp_CHANGELOG.md |
Temporary changelog content removed. |
mist.postman_env.json |
Adds new path variables. |
mist.openapi.yaml |
Generated OpenAPI specification updates. |
CHANGELOG.md |
Version 2609.1.0 release notes; invalid_aps should match the schema field invalid_device_ids (nit, 3 votes). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
tmunzer-AIDE
left a comment
There was a problem hiding this comment.
I'm a bit worried about the anyOf.required approach. We need to validate the API portal is able to render it as expected and it won't break the terraform provider
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 8 changed files in this pull request and generated 4 comments.
Suppressed comments (1)
workdir/openapi.yaml:87508
- This updated description is not actionable: it is a sentence fragment (
Optional...,which ap) and documents afalsedefault without declaring that default in the schema. Replace it with a complete description and adddefault: falseso generated clients receive the documented behavior.
tmunzer-AIDE
left a comment
There was a problem hiding this comment.
Thanks. Wondering if it's possible to add comments to replace the "required.anyOf", at least to provide this information somewhere in the OAS.
wprins-JNPR
left a comment
There was a problem hiding this comment.
lgtm, please see the one open comment by @tmunzer-AIDE
No description provided.