Skip to content

MIST-221032 update openAPI schema - #73

Open
Kevin-DeJong wants to merge 5 commits into
masterfrom
MIST-221032_Update_OpenAPI_schema
Open

Kevin-DeJong wants to merge 5 commits into
masterfrom
MIST-221032_Update_OpenAPI_schema

Conversation

@Kevin-DeJong

Copy link
Copy Markdown
Collaborator

No description provided.

@Kevin-DeJong
Kevin-DeJong requested review from tmunzer-AIDE and wprins-JNPR and a lite review from Copilot and removed request for tmunzer-AIDE September 10, 2026 05:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Mist OpenAPI specification to version 2609.1.0 with new APIs, schemas, generated artifacts, and release documentation.

Changes:

  • Adds security-zone, SCEP event search, flow-capture, and map-stack APIs.
  • Expands inventory, spectrum, multicast, NAC, and related schemas.
  • Refreshes OpenAPI, Postman environment, and changelog artifacts.

Reviewed changes

Copilot reviewed 5 out of 8 changed files in this pull request and generated 6 comments.

Show a summary per file
File Summary
workdir/openapi.yaml Source schema updates. Findings include missing generated Postman operations (moderate, 3 votes), an incompatible spectrum-analysis requirement (moderate, 3 votes), removal of enabled compatibility (critical, 2 votes), incomplete flow-capture WebSocket documentation (nit, 2 votes), and removal of map field aliases (critical, 1 vote).
tmp_CHANGELOG.md Temporary changelog content removed.
mist.postman_env.json Adds new path variables.
mist.openapi.yaml Generated OpenAPI specification updates.
CHANGELOG.md Version 2609.1.0 release notes; invalid_aps should match the schema field invalid_device_ids (nit, 3 votes).

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread workdir/openapi.yaml
Comment thread workdir/openapi.yaml
Comment thread workdir/openapi.yaml
Comment thread workdir/openapi.yaml Outdated
Comment thread CHANGELOG.md Outdated
Comment thread workdir/openapi.yaml Outdated

@tmunzer-AIDE tmunzer-AIDE left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit worried about the anyOf.required approach. We need to validate the API portal is able to render it as expected and it won't break the terraform provider

Comment thread workdir/openapi.yaml Outdated
Comment thread workdir/openapi.yaml Outdated
Comment thread workdir/openapi.yaml Outdated
Comment thread workdir/openapi.yaml
Comment thread workdir/openapi.yaml Outdated
Comment thread workdir/openapi.yaml Outdated
Comment thread workdir/openapi.yaml
Comment thread workdir/openapi.yaml Outdated
Comment thread workdir/openapi.yaml Outdated
Comment thread workdir/openapi.yaml Outdated
Comment thread workdir/openapi.yaml
Comment thread workdir/openapi.yaml
Comment thread workdir/openapi.yaml Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 8 changed files in this pull request and generated 4 comments.

Suppressed comments (1)

workdir/openapi.yaml:87508

  • This updated description is not actionable: it is a sentence fragment (Optional..., which ap) and documents a false default without declaring that default in the schema. Replace it with a complete description and add default: false so generated clients receive the documented behavior.

Comment thread workdir/openapi.yaml
Comment thread workdir/openapi.yaml
Comment thread workdir/openapi.yaml
Comment thread workdir/openapi.yaml

@tmunzer-AIDE tmunzer-AIDE left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Wondering if it's possible to add comments to replace the "required.anyOf", at least to provide this information somewhere in the OAS.

Comment thread workdir/openapi.yaml Outdated
wprins-JNPR
wprins-JNPR previously approved these changes Sep 15, 2026

@wprins-JNPR wprins-JNPR left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, please see the one open comment by @tmunzer-AIDE

tmunzer-AIDE
tmunzer-AIDE previously approved these changes Sep 17, 2026

@tmunzer-AIDE tmunzer-AIDE left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants