Repository navigation
The build page says a damaged link is damaged, and how to bring its source - #39
Merged
Merged
Conversation
…ource A chat writes the link out in its reply, and a compressed source survives no wrong character: a link ChatGPT gave held 43 characters of its own in place of 37. The page then said the link had carried the source, over an empty box, with the reason under Build, out of sight. For a link whose source cannot be read, the hero now says the link arrived damaged, and the ways to bring the source are above its box: ask the chat for the link again, open the source file it gave, or paste the source. They go once a source is there. The reason goes to the console. Closes #38.
There was a problem hiding this comment.
No issues found across 3 files
Tip: cubic could auto-approve low-risk PRs like this, if it thinks it's safe to merge. Learn more
View guided diff | Turn on auto-fix | Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #38.
For a link whose source cannot be read, the build page now says the link arrived damaged and shows what to do, above the source box. Before this, it said the link carried an activity, over an empty box, and put the only message under Build, out of sight.
What changes
.source.jsonfile it gave (a button opens the file picker), or paste the source. "The link carried it here" is hidden. The step's marker turns red, as for a source that is not JSON.Files:
src/h5p/build/index.njk,src/h5p/build/build-page.ts, and one rule insrc/assets/site.css(a classunreadon<html>, besidelinked).Tested
pnpm install --frozen-lockfile,pnpm typecheckandpnpm buildpass..source.jsonfrom the damaged state built and played the quiz. The address then carried that source exactly, and a reload behaved as an ordinary link.Summary by cubic
Fixes the build page so a link whose source cannot be read now says the link arrived damaged and shows how to bring the source, instead of claiming it carried an activity over an empty box.
.source.jsonfile it gave, or paste the source.Closes #38.
Written for commit d5c11d1. Summary will update on new commits.