Repository navigation
h5p-author: a type's fields without npm, and one link in the hand-over - #193
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
…page route's cubic's review of #193: step 5's list gave no other web address and the preview command where there is no link, so read alone it took the page's address from a chat that has only the source to paste, and gave it a command for a package that does not exist. Step 5 now opens by sending that case to step 3's build page route (the link, or the whole source and the page's address), and step 3's paragraph for it names the address and holds only where nothing is built here. Haiku as a chat with no tools: 5 of 5 replies right before and after (source in a json block, the page's address, no link, no preview command, the picture named). In Claude Code's place: 2 of 2 Question Sets the exact link alone, the picture run no address and the preview command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #192.
This PR changes two things in the h5p-author skill's text (
skills/h5p-author/SKILL.md) and updates the matching rules indesign/author.md. No code changes, and the build is unchanged.What changes
node h5p-author.mjs schema <Type> --libraries parts.No link: the source names files, which a link cannot carry.instead of the feedback line.libraries.txtlink, the tools to go to next, orreport.jsonand its revision. The licences stay as a sentence and the screenshot stays.Tested
All runs used Haiku as a subagent, the weakest model first.
Schema: the skill read by its link, with no package registry. Crossword and Find the Words, two runs each per text.
schemacallAll 7 packages pass
h5p-verify.Hand-over: the skill installed, with a shell and npm, the verifier left out. Same prompts as 0.9.5's measurement.
Commands: both one-liners run as written. A plain source gives one line: a link that decodes to the source byte for byte. A source that names a file gives the reason alone.
The build page's route (after cubic's review): Haiku as a chat with no tools, the skill's text and the type's file pasted in. Five chats per text: three Question Sets, and two Multiple Choice questions naming the user's picture.
jsonblock beside the page's address, no linkWhat is lost and not covered
revision.id="feedback-heading", because installed copies of 0.9.5 print its address.Release
This is a patch, h5p-author 0.9.6, skill text only. After it: the org site's pin bump,
npx skills update -g, and a new Claude app zip.Summary by cubic
Updates the h5p-author skill's text so two gaps are closed: a type's fields are fetched without npm, and the hand-over carries one web address, the build page's link. No code changes; the design rules in
design/author.mdare updated to match.A type's fields where npm cannot install
node h5p-author.mjs schema <Type> --libraries parts.--librariesin 4 of 4 runs; with the command, 4 of 4 got the fields and built a packageh5p-verifypassed.One web address in the hand-over
No link: the source names files, which a link cannot carry.for a source that names files.libraries.txtlink, the preview command, the next-step tools, andreport.jsonwith its revision are gone. Licences stay a sentence, the screenshot stays, and the preview command is given only where there is no link.Written for commit b665e48. Summary will update on new commits.