Skip to content

Mintlayer app - new main PR#7

Open
ImplOfAnImpl wants to merge 335 commits into
masterfrom
feature/refactor-too-big
Open

Mintlayer app - new main PR#7
ImplOfAnImpl wants to merge 335 commits into
masterfrom
feature/refactor-too-big

Conversation

@ImplOfAnImpl

@ImplOfAnImpl ImplOfAnImpl commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

This supersedes #1, which has too many comments and is hard to navigate.

Note:

  1. The code in the two PRs have diverged as they contain two different refactorings, see Feature/mintlayer app #1 (comment)
  2. Some review comments from the old PR may still be relevant, so all the comments must be rechecked.

agrojean-ledger and others added 30 commits November 15, 2023 15:41
@agrojean-ledger
Remove local version of nanos_ui in Cargo.toml
b134372
@agrojean-ledger
Format
b57d5bd
@agrojean-ledger
Use dependencies from the new SDK workspace.
a132cd4 
Code cleanup.
@agrojean-ledger
Introduce new App Status Words enum and use it instead of io::Reply a…
337f1b9 
…s return type
@agrojean-ledger
Update CI
3c16549
@agrojean-ledger
Merge pull request #31 from LedgerHQ/update-app
0aafd40 
Update app : features, UI, tests, CI.
@agrojean-ledger
Update dependencies to latest SDK versions for update .elf metadatas
955db01
@agrojean-ledger
Update CI with reusable workflows
7821659
@agrojean-ledger
Update app manifest to add pytest directory field.
b98ef03
@agrojean-ledger
Ignore word "crate" in misspelling checks.
83f1e4e
@agrojean-ledger
Rename python tests checks workflow for clarity.
1d35ecc
@agrojean-ledger
Add "name" field in Cargo.toml [package.metadata.ledger] category
69ef4c2
@agrojean-ledger
Fix static analysis
6972549
@agrojean-ledger
Update pending review function
23ec722
@agrojean-ledger
Add "clear pending review" fixture in python tests.
ef5d187
@agrojean-ledger
Use v1 of reusable workflows in CI as the work branch for rust suppor…
031d292 
…t has been merged.
@agrojean-ledger
Merge pull request #35 from LedgerHQ/update-ci
683338a 
Update CI
@agrojean-ledger
Use json + serde for Tx deserialization.
6bef1f8
@agrojean-ledger
Small improvements in APDU handling
8d5c4aa
@agrojean-ledger
Code cleanup
5d13761
@kingofpayne @agrojean-ledger
Destination address now stored as u8 array
ca88f2d
@kingofpayne @agrojean-ledger
Use hex crate for hexadecimal formatting
7f7ea72
@kingofpayne @agrojean-ledger
Amount now as coin string and u64
c335be5
@kingofpayne @agrojean-ledger
Fixed error management in ui_display_tx
4548218
@kingofpayne @agrojean-ledger
Minor code improvement
d17979b 
Better use of rust expression pattern matching.
@kingofpayne @agrojean-ledger
Destination address to uppercase
5ff6f1d
@agrojean-ledger
Fix static analysis
78e4b1c
@agrojean-ledger
Fix python tests lint and type checking
72a9dbe
@agrojean-ledger
Update tests snapshots
0c2c24e
@agrojean-ledger
Merge pull request #34 from LedgerHQ/use-serde
3182781 
Use serde
OBorce and others added 29 commits December 24, 2025 12:36
@OBorce
fix comments
ad084ac
@OBorce
bump deps and toolchain
9ca7570
@OBorce
Move StatusWord to messages crate
dbc4134
@OBorce
restrict message display to printable ASCII characters only
9c7c50e
@OBorce
Add Ping command
985e76c
@ImplOfAnImpl
Update mintlayer-core-primitives repo revision. Enable disabled CI wo…
ffe0d62 
…rkflows. Run cargo-fmt. Update ledger_device_sdk version.
@ImplOfAnImpl
Merge pull request #3 from mintlayer/update_ml_primitives_rev
a544449 
Update mintlayer-core-primitives repo revision. Enable disabled CI workflows.
@OBorce
Refactor response types
928777c
@OBorce
Reafactor utils and imports
4391b8b
@OBorce
Extract Tx summary collector
26fb5f2
@OBorce
fix comments
bb982d7
@OBorce
fix tests
deaa943
@OBorce
fix tests
55badf3
@ImplOfAnImpl
Reduce app stack usage by boxing large objects
a249cde
@ImplOfAnImpl
Add a doc file about memory and stack usage
ab9d858
@OBorce
Transfer changes from other feature branch
223c0ea
@ImplOfAnImpl @OBorce
Move app src to a separate lib crate in ./crates, move "messages" the…
d861227 
…re as well for consistency
@ImplOfAnImpl @OBorce
Use a workspace in the root Cargo.toml to avoid duplication. Rename "…
8d10988 
…messages" to "mintlayer-messages".
@ImplOfAnImpl @OBorce
Allow running unittests on speculos
a9d2597
@ImplOfAnImpl @OBorce
Add a script to run clippy
3336119
@ImplOfAnImpl @OBorce
Add a sample test
32206e6
@ImplOfAnImpl @OBorce
Remove target specification from .cargo/config.toml
3d85d35
@ImplOfAnImpl @OBorce
Add unit test runner script and a CI job
4f78de7
@ImplOfAnImpl @OBorce
Minor cleanup of CI jobs
313e61f
@ImplOfAnImpl @OBorce
Minor cleanup
b4d9111
@ImplOfAnImpl @OBorce
Fix clippy errors. Minor cleanup in run_extra_checks.sh
eb03b18
@ImplOfAnImpl
Merge pull request #4 from mintlayer/nanox_so_fix
89e9fb0 
Nanox so fix
@ImplOfAnImpl
Merge pull request #5 from mintlayer/add_ability_to_write_unittests
9e99203 
Add ability to write unittests
@OBorce @ImplOfAnImpl
Add technical specification
16dce6a
@ImplOfAnImpl ImplOfAnImpl mentioned this pull request Jun 17, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.