Skip to content

build: silence -Wextra warnings across the library, tests and examples #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harshavardhana merged 1 commit into from
Aug 11, 2026
+19 −19
Merged

build: silence -Wextra warnings across the library, tests and examples #246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/baseclient.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,11 +130,10 @@ void BaseClient::HandleRedirectResponse(std::string& code, std::string& message,
}
}

Result<Response> BaseClient::GetErrorResponse(http::Response resp,
std::string_view resource,
http::Method method,
const std::string& bucket_name,
const std::string& object_name) {
Result<Response> BaseClient::GetErrorResponse(
http::Response resp, [[maybe_unused]] std::string_view resource,
http::Method method, const std::string& bucket_name,
const std::string& object_name) {
if (!resp.error.empty()) {
return tl::make_unexpected(error::Error(resp.error));
}
Expand Down
13 changes: 7 additions & 6 deletions src/client.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,8 @@ struct ScopedRDMARegistration {

} // namespace

ListObjectsResult::ListObjectsResult(error::Error err) : failed_(true) {
ListObjectsResult::ListObjectsResult([[maybe_unused]] error::Error err)
: failed_(true) {
resp_ = std::make_shared<ListObjectsResponse>();
itr_ = resp_->contents.end();
}
Expand Down Expand Up @@ -384,7 +385,7 @@ void ListObjectsResult::Populate() {
}
}

RemoveObjectsResult::RemoveObjectsResult(error::Error err) {
RemoveObjectsResult::RemoveObjectsResult([[maybe_unused]] error::Error err) {
done_ = true;
itr_ = resp_.errors.end();
}
Expand Down Expand Up @@ -1023,7 +1024,7 @@ Result<ComposeObjectResponse> Client::ComposeObject(ComposeObjectArgs args) {
amu_args.region = args.region;
amu_args.object = args.object;
amu_args.upload_id = upload_id;
AbortMultipartUpload(amu_args);
(void)AbortMultipartUpload(amu_args);
}

return resp;
Expand Down Expand Up @@ -1586,7 +1587,7 @@ Result<PutObjectResponse> Client::PutObject(PutObjectArgs args) {
amu_args.region = std::move(args.region);
amu_args.object = std::move(args.object);
amu_args.upload_id = upload_id;
AbortMultipartUpload(amu_args);
(void)AbortMultipartUpload(amu_args);
}
return tl::make_unexpected(first_err);
}
Expand All @@ -1611,7 +1612,7 @@ Result<PutObjectResponse> Client::PutObject(PutObjectArgs args) {
amu_args.region = std::move(args.region);
amu_args.object = std::move(args.object);
amu_args.upload_id = upload_id;
AbortMultipartUpload(amu_args);
(void)AbortMultipartUpload(amu_args);
}
if (!cmu_resp) {
return tl::make_unexpected(cmu_resp.error());
Expand Down Expand Up @@ -1658,7 +1659,7 @@ Result<PutObjectResponse> Client::PutObject(PutObjectArgs args) {
amu_args.region = std::move(args.region);
amu_args.object = std::move(args.object);
amu_args.upload_id = upload_id;
AbortMultipartUpload(amu_args);
(void)AbortMultipartUpload(amu_args);
}

return resp;
Expand Down
16 changes: 8 additions & 8 deletions tests/tests.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -798,7 +798,7 @@ class Tests {
try {
minio::s3::RemoveBucketArgs args;
args.bucket = b;
client_.RemoveBucket(args);
(void)client_.RemoveBucket(args);
} catch (...) {
}
};
Expand Down Expand Up @@ -1101,7 +1101,7 @@ class Tests {
} catch (const std::runtime_error&) {
minio::s3::RemoveBucketArgs args;
args.bucket = bucket_name;
client_.RemoveBucket(args);
(void)client_.RemoveBucket(args);
throw;
}
}
Expand Down Expand Up @@ -1243,7 +1243,7 @@ class Tests {
} catch (const std::runtime_error&) {
minio::s3::RemoveBucketArgs args;
args.bucket = bucket_name;
client_.RemoveBucket(args);
(void)client_.RemoveBucket(args);
throw;
}
}
Expand Down Expand Up @@ -1296,7 +1296,7 @@ class Tests {
try {
minio::s3::RemoveBucketArgs args;
args.bucket = b;
client_.RemoveBucket(args);
(void)client_.RemoveBucket(args);
} catch (...) {
}
}
Expand Down Expand Up @@ -1371,7 +1371,7 @@ class Tests {
{
minio::s3::RemoveBucketArgs args;
args.bucket = bucket_name;
client_.RemoveBucket(args);
(void)client_.RemoveBucket(args);
}
}

Expand Down Expand Up @@ -1405,7 +1405,7 @@ class Tests {
{
minio::s3::RemoveBucketArgs args;
args.bucket = bucket_name;
client_.RemoveBucket(args);
(void)client_.RemoveBucket(args);
}
}

Expand Down Expand Up @@ -1439,7 +1439,7 @@ class Tests {
{
minio::s3::RemoveBucketArgs args;
args.bucket = bucket_name;
client_.RemoveBucket(args);
(void)client_.RemoveBucket(args);
}
}

Expand Down Expand Up @@ -1473,7 +1473,7 @@ class Tests {
{
minio::s3::RemoveBucketArgs args;
args.bucket = bucket_name;
client_.RemoveBucket(args);
(void)client_.RemoveBucket(args);
}
}

Expand Down
Loading