Repository navigation
fix: keep the walk flat key sorted on Windows - #3
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
balamurugana
force-pushed
the
exhibit-walk-order
branch
from
October 13, 2026 08:26
ed630ef to
599971b
Compare
balamurugana
changed the title
balamurugana
force-pushed
the
exhibit-walk-order
branch
from
October 13, 2026 08:29
599971b to
bd70699
Compare
A directory is taken to end in `/` before sorting, so the walk comes out in flat key order: the order an object store lists the same names in. byName appended os.PathSeparator instead, which is that byte on Unix but 0x5C on Windows, above the digits and the upper case letters, so a directory there sorted after siblings it should have come before. Unix is unchanged, the separator there being `/` already. The test asserts the documented order, and the workflow runs it on ubuntu, macos and windows. Signed-off-by: Bala.FA <bala@minio.io>
balamurugana
force-pushed
the
exhibit-walk-order
branch
from
October 13, 2026 08:34
bd70699 to
e625302
Compare
harshavardhana
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A directory is taken to end in
/before sorting, so the walk comes out inflat key order: the order an object store lists the same names in. byName
appended os.PathSeparator instead, which is that byte on Unix but 0x5C on
Windows, above the digits and the upper case letters, so a directory there
sorted after siblings it should have come before.
Unix is unchanged, the separator there being
/already. The test assertsthe documented order, and the workflow runs it on ubuntu, macos and windows.