Repository navigation
chore(ci): delete the workflows that build and deploy the blog (ENG-2000) - #39
Open
lucas-koontz wants to merge 1 commit into
Open
lucas-koontz wants to merge 1 commit into
lucas-koontz wants to merge 1 commit into
Conversation
Delete the only two workflows in this repository. dev-build-deploy-on-main.yaml ran on every push to main. It built the blog image and helm-installed every chart under deployment/ into the dev namespace. prod-build-deploy-on-release.yaml ran on a published release or a manual dispatch, and did the same into the prod namespace. Both workflows ran on the mdb-dev and mdb-prod self-hosted runners. GitHub recommends GitHub-hosted runners for public repositories, but moving these jobs there would keep deploying a blog that no public URL reaches. mindsdb.com/blog now redirects to https://mindshub.ai/blog, a site this repository does not build. The last deploys ran on 2025-06-04 (dev) and 2025-02-13 (prod). With no workflow on main, a push to main or a manual dispatch starts no job. The charts under deployment/ and the Dockerfile stay. Their READMEs describe a manual helm install, which this change leaves as it is. Part of Lucas Koontz's ticket "Take the public repos off the credentialed runner group and require devops to release a privileged run". Refs: ENG-2000
This was referenced Oct 4, 2026
Draft
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User story
As a maintainer of this repository
I want
mainto hold no workflow that builds or deploys the old blogSo that a push to
mainor a manual dispatch starts no job on a self-hosted runnerWhy this matters
A maintainer who merges to
maintoday rebuilds the blog image and redeploys its charts into thedevnamespace, and a published release does the same inprod. No reader sees either deploy, becausehttps://mindsdb.com/blogredirects tohttps://mindshub.ai/blog, a site this repository does not build. Both workflows run on self-hosted runners, and GitHub recommends GitHub-hosted runners for public repositories. Moving the jobs to GitHub-hosted runners would only keep an unused deploy alive, so this PR deletes both workflows.Acceptance criteria
mainhas no.githubdirectory, andgh api 'repos/mindsdb/hashnode-starter-kit/contents/.github/workflows?ref=main'returns 404.mainstarts no workflow run.mdb-dev,mdb-prod,mindsdb/github-actionsor either deleted workflow..github/workflows/changes.deployment/, theDockerfileand both chart READMEs stay as they are.How to test
Start from a checkout of
chore/eng-2000-drop-cluster-deploys, withghsigned in to any GitHub account.git diff --name-status origin/main...HEAD. Expect exactly twoDlines, for.github/workflows/dev-build-deploy-on-main.yamland.github/workflows/prod-build-deploy-on-release.yaml, and nothing else.git grep -n -E 'mdb-dev|mdb-prod|mindsdb/github-actions|build-deploy-on-(main|release)'. Expect no output.curl -sI https://mindsdb.com/blog. Expect a301withlocation: https://mindshub.ai/blog, which shows no reader depends on these deploys.gh api 'repos/mindsdb/hashnode-starter-kit/contents/.github/workflows?ref=main'. ExpectHTTP 404.gh api "repos/mindsdb/hashnode-starter-kit/actions/runs?head_sha=$(gh api repos/mindsdb/hashnode-starter-kit/commits/main --jq .sha)" --jq .total_count. Expect0. A workflow that survived the merge would start a run here, so this is the check most likely to catch a partial fix.Notes for the reviewer
Merge order: independent. This PR depends on no sibling, and no sibling depends on it, so it can merge as soon as it is approved.
Operator steps: none. Nothing has to run before or after the merge.
Rollback: revert the squash commit on
main. The revert restores both workflows exactly as they were, triggers included, so the next push tomainwould build and deploy intodevagain.This PR uninstalls nothing. It deletes the workflow files only. Anything an earlier run installed stays until someone removes it with
helm uninstall.Deliberate omissions.
deployment/and theDockerfilestay. Nothing in this repository uses them after this change. Their READMEs describe a manualhelminstall and never mention these workflows, so they stay accurate. Removing them is a separate choice.No checks run on this PR. No workflow remains to run, and
mainrequires none to merge.Verified locally
git fetch origin, thenorigin/maincompared with the branch baseorigin/mainis stillc3669aa, the commit this branch starts from, so the rebase changed nothinggit diff --stat origin/main...HEADactionlint1.7.12 on the two workflows atorigin/mainmdb-devthree times andmdb-prodonceactionlint1.7.12 at the branch head.github/workflowsdirectory remainszizmor1.28.0, regular persona, offline, on the workflows atorigin/mainzizmor1.28.0, regular persona, offline, at the branch headgit grepat the branch head over the tracked files except.env*, formdb-dev,mdb-prod,mindsdb/github-actions,setup-env,build-push-ecr,aws-helm,DevOps-Nirvanaand both workflow namesmindsdborganizationcurlon 2026-10-04 at 05:13 UTChttps://mindsdb.com/blogandhttps://www.mindsdb.com/blogreturn 301 tohttps://mindshub.ai/blog, which serves 200 from an Astro site.https://hashnode.dev.mindsdb.com/blog, thedevenvironment URL, returns 404devdeployment ran on 2025-06-04 atc3669aa. The lastproddeployment ran on 2025-02-13 atv25.2.3.0origin/mainShips with
Part of ENG-2000. This PR deploys nothing, so it carries no
Deploys:lines and nodeploylabel.Merge order
argocd-pr-env-deployto the github-actions merge commit from step 2. The operator also creates the deployer's GitHub App and sets its client ID and private key in thestagingandprodenvironments of cowork and cowork-server.staging. mindsdb/minds_python_sdk#90, mindsdb/engine#7, mindsdb/data-vault#4 and this PR merge intomain. These four depend on no other step.stagingtag, mindsdb/scratchpad-controller#80 and mindsdb/argocd-envs#25 merge.stagingtomainin their next release.mainbuilds push through the prod writer roles.mainandstaging.Sibling PRs, in merge order:
build-push-ecrgainsbuilder: localfor GitHub-hosted builds, andargocd-pr-env-deploytakes the pull request as inputs and checks its image in the dev tier.