feat: enhance table UI by DharunMR · Pull Request #6291 · mindersec/minder

DharunMR · 2026-04-06T16:22:19Z

Summary

This PR overhauls the internal CLI table engine to provide a more professional and readable user interface across all Minder commands. By leveraging go-pretty/v6 more effectively, the CLI now supports visual grouping of data in terminal.

Key Improvements

Auto-Merging Logic: Implemented vertical merging for repetitive data in the first and second columns (e.g., Time, Entity, Owner). This reduces visual noise and groups related evaluation results or repositories into "blocks."
Dynamic Column Scaling: Replaced fixed width calculations with percentage-based distribution. The UI now intelligently allocates space based on column count, ensuring primary information (like Rule Definitions or Descriptions) gets the most room.
Terminal Boundary Protection: Implemented strict terminal width detection and enforced WrapSoft text wrapping. This prevents the "clipping" issue (the ≈ symbol) and ensures the table border always aligns with the terminal edge.
Unified Styling: Standardized the Rounded table style across all commands, including repo, profile, ruletype, history, project, and provider.

After Changes

coveralls · 2026-04-06T16:33:14Z

coverage: 59.314% (-0.1%) from 59.418% — DharunMR:enhance-table-UI into mindersec:main

evankanderson

Thanks for looking at this! A few questions, but the new output doesn't look worse than the old (I don't have a strong opinion as to whether or not it's better, except that it seems like history list may have less data than before).

DharunMR · 2026-04-07T07:32:25Z

Regarding the history list output I have verified this locally against the previous version, no data is being getting modified

Previously my approach based on a central columnSpecs map. This required manual updates every time a new command or header was added. My new approach uses updateWidths to track the actual maxColWidths of the data being injected. Removed borders in table

For Profile tables , I've implemented a SetEqualColumns toggle. Since profile data is highly structured, an equal distribution

I have updated the PR description with screenshots of every table output to demonstrate that the dynamic scaling

evankanderson

I'm liking the reduced dependencies for go-pretty over charmbracelet; a few comments and styling questions, but I think this is getting close.

evankanderson · 2026-04-08T19:56:07Z

-	// TODO: add automerge common cells (name/entity)
+		[]string{"Entity", "Rule Name", "Status", "Details"}).
+		SetAutoMerge(true).
+		SetEqualColumns(true)


"Status" is usually short, and "Details" is often long on failure, so you may want to adjust those.

I implemented a calculation in the Render logic that allocates terminal space based on the proportional length of the content in each column. This ensures the table works fine for every cmd

evankanderson · 2026-04-08T20:03:39Z

 	failureStatus      = "failure"
 	errorStatus        = "error"
 	skippedStatus      = "skipped"
-	pendingStatus      = "pending"


Why remove this?

it is unused so i removed (re-added it)

evankanderson · 2026-04-08T20:07:40Z

 	AddRowWithColor(row ...layouts.ColoredColumn)
-	// Render outputs the table to stdout (TODO: make output configurable)
 	Render()
-	// SeparateRows ensures each row is clearly separated (probably because it is multi-line)


I think a comment for this method makes sense.

fixed the todo, will re-add 2nd comment

evankanderson · 2026-04-08T20:08:16Z

 type Table interface {
 	AddRow(row ...string)
 	AddRowWithColor(row ...layouts.ColoredColumn)
-	// Render outputs the table to stdout (TODO: make output configurable)


Oooh! Now I see what's going on with the other PR -- it looks like table rendering doesn't use cmd.Out, huh?

How easy would that be to fix?

Signed-off-by: DharunMR <maddharun56@gmail.com>

evankanderson

This looks close enough that I'd like to merge it, despite a few cleanup items that you could open another PR for if you want.

evankanderson · 2026-04-10T06:12:59Z

+
 	renderRuleEvaluationStatusTable(resp.Data, historyTable, emoji)
 	historyTable.Render()
 	fmt.Println("")


You want to update this output line, too.

Sry, I dont get what to update?

The fmt.Println("") is going to write to os.Stdout; you probably want to change this to:

Suggested change

fmt.Println("")

w.Write("\n")

(But this can happen in your other testing PR)

evankanderson · 2026-04-10T06:13:17Z

 		// Ordering is fixed for evaluation history
 		// log and the next page points to older
 		// records.
 		msg := fmt.Sprintf("Older records: %s",


evankanderson · 2026-04-10T06:16:32Z


 func marshalStructOrEmpty(v *structpb.Struct) string {
-	if v == nil {
+	if len(v.AsMap()) == 0 {


We should do the AsMap conversion once (or check len(v.GetFields()) here to avoid any conversion the first time).

evankanderson · 2026-04-10T06:33:08Z

-func (l *lipGlossTable) AddRow(row ...string) {
-	l.table.Row(row...)
-	l.rows++
+func (l *goPrettyTable) SetAutoMerge(merge bool) Table {


This should probably be "g" for the object; I'm surprised none of the linters complained.

evankanderson · 2026-04-10T06:41:55Z

+			if l.numCols > 0 {
+				// If we have a deficit or surplus due to integer rounding,
+				// adjust the last column to snap to the edge.
+				if assignedWidths[l.numCols-1]+diff > 0 {


This should probably be 5 to line up with "share", right?

yes wraping words too short will be hard to read, i changed it

evankanderson · 2026-04-10T06:49:28Z

+
+	l.t.SetColumnConfigs(configs)
+
+	l.t.SetAllowedRowLength(w)


This seems to be deprecated in favor of:

Suggested change

l.t.SetAllowedRowLength(w)

l.t.Style.Size.WidthMax = w

you are absolutely right

DharunMR · 2026-04-10T07:11:35Z

This looks close enough that I'd like to merge it, despite a few cleanup items that you could open another PR for if you want.

Yes i'll open a seperate pr for cleanup tonight

evankanderson · 2026-04-10T07:31:09Z

The test failure appears to be legitimate, and does not appear in upstream/main. I think you can just drop the change from internal/datasources/rest/handler.go.

Signed-off-by: DharunMR <maddharun56@gmail.com>

DharunMR · 2026-04-10T14:49:41Z

@evankanderson i've also made changes as recent suggestion

This looks close enough that I'd like to merge it, despite a few cleanup items that you could open another PR for if you want.

I have made changes, except this "You want to update this output line, too."

evankanderson · 2026-04-10T16:12:23Z

+
 	renderRuleEvaluationStatusTable(resp.Data, historyTable, emoji)
 	historyTable.Render()
 	fmt.Println("")


The fmt.Println("") is going to write to os.Stdout; you probably want to change this to:

Suggested change

fmt.Println("")

w.Write("\n")

evankanderson · 2026-04-10T16:12:33Z

+
 	renderRuleEvaluationStatusTable(resp.Data, historyTable, emoji)
 	historyTable.Render()
 	fmt.Println("")


(But this can happen in your other testing PR)

DharunMR requested a review from a team as a code owner April 6, 2026 16:22

evankanderson reviewed Apr 7, 2026

View reviewed changes

DharunMR force-pushed the enhance-table-UI branch 3 times, most recently from 4fa2ff2 to c217bd5 Compare April 7, 2026 12:31

DharunMR requested a review from evankanderson April 8, 2026 08:34

evankanderson reviewed Apr 8, 2026

View reviewed changes

DharunMR force-pushed the enhance-table-UI branch from 7bf6775 to 3c87969 Compare April 9, 2026 05:51

DharunMR mentioned this pull request Apr 10, 2026

Implement Isolated, Deterministic Test Suite for ruletype CLI Subcommands #6286

Merged

DharunMR added 4 commits April 10, 2026 10:20

fixed the table output in CLI

71afd5f

Signed-off-by: DharunMR <maddharun56@gmail.com>

improves history list

5e103c5

Signed-off-by: DharunMR <maddharun56@gmail.com>

enhanced the table with dynamic resize using data in it

8f402f8

Signed-off-by: DharunMR <maddharun56@gmail.com>

changed render to use cmd.Out

518aa5f

Signed-off-by: DharunMR <maddharun56@gmail.com>

DharunMR force-pushed the enhance-table-UI branch from 3c87969 to 518aa5f Compare April 10, 2026 04:57

evankanderson previously approved these changes Apr 10, 2026

View reviewed changes

add changes as suggested

13c8b18

Signed-off-by: DharunMR <maddharun56@gmail.com>

DharunMR dismissed evankanderson’s stale review via 13c8b18 April 10, 2026 14:35

DharunMR requested a review from evankanderson April 10, 2026 14:46

evankanderson approved these changes Apr 10, 2026

View reviewed changes

evankanderson merged commit 8fb1b27 into mindersec:main Apr 10, 2026
25 checks passed

Conversation

DharunMR commented Apr 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Key Improvements

After Changes

Uh oh!

coveralls commented Apr 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

evankanderson left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DharunMR commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

evankanderson left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DharunMR Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

evankanderson left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DharunMR Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DharunMR commented Apr 10, 2026

DharunMR commented Apr 6, 2026 •

edited

Loading

coveralls commented Apr 6, 2026 •

edited

Loading

DharunMR commented Apr 7, 2026 •

edited

Loading

DharunMR Apr 9, 2026 •

edited

Loading

DharunMR Apr 10, 2026 •

edited

Loading