Repository navigation
chg: ⬆️ update dependencies and add integration testing - #41
Merged
Merged
Conversation
sebastianMindee
requested review from
despprie
and
a balanced review from Copilot
October 2, 2026 11:57
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The production library-mode worker packaging needs a consumer-level integration test before approval.
Review effort: Balanced
Findings: 1
What changed in this PR
Updates major dependencies and modernizes PDF/HEIC processing while dropping legacy runtime support.
Changes:
- Upgrades Konva and PDF.js; removes UUID.
- Bundles and lazily loads PDF workers and HEIC conversion.
- Adapts rendering and Konva APIs to newer versions.
| File | Description |
|---|---|
vite.config.ts |
Configures ES module workers. |
tsconfig.json |
Adds Vite client types. |
src/utils/pdfWorker.ts |
Creates an inline PDF worker. |
src/utils/pdf.ts |
Lazily initializes PDF.js. |
src/utils/image.ts |
Lazily imports HEIC conversion. |
src/utils/getPDFPageCount.ts |
Uses centralized PDF loading. |
src/utils/getImagesFromPDF.ts |
Updates PDF rendering API. |
src/utils/functions.ts |
Uses updated Konva typings. |
src/common/constants.ts |
Safely handles optional stroke values. |
package.json |
Updates dependencies and Node requirement. |
pnpm-lock.yaml |
Locks upgraded dependency versions. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Cache-busting only the entry module leaves the lazy PDF module shared, invalidating multiple worker lifecycle tests.
Review effort: Balanced
Findings: 3
Open (3)
Resolved since last review (1)
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

PR Details
Bump most libraries and remove support for old browsers.
Description
Related Issue
Motivation and Context
How Has This Been Tested
Types of changes
Checklist