Skip to content

chg: ⬆️ update dependencies and add integration testing - #41

Merged
sebastianMindee merged 3 commits into
build-chainfrom
breaking-changes
Oct 2, 2026
Merged

sebastianMindee merged 3 commits into
build-chainfrom
breaking-changes

Conversation

@sebastianMindee

@sebastianMindee sebastianMindee commented Oct 2, 2026 •

Copy link
Copy Markdown
Collaborator

PR Details

Bump most libraries and remove support for old browsers.

  • add integration testing

Description

Related Issue

Motivation and Context

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have added type hints (flow) to cover my changes.
  • All new and existing tests passed.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The production library-mode worker packaging needs a consumer-level integration test before approval.

Review effort: Balanced
Findings: 1 Medium severity

Open (1)
What changed in this PR

Updates major dependencies and modernizes PDF/HEIC processing while dropping legacy runtime support.

Changes:

  • Upgrades Konva and PDF.js; removes UUID.
  • Bundles and lazily loads PDF workers and HEIC conversion.
  • Adapts rendering and Konva APIs to newer versions.
File Description
vite.config.ts Configures ES module workers.
tsconfig.json Adds Vite client types.
src/​utils/​pdfWorker.ts Creates an inline PDF worker.
src/​utils/​pdf.ts Lazily initializes PDF.js.
src/​utils/​image.ts Lazily imports HEIC conversion.
src/​utils/​getPDFPageCount.ts Uses centralized PDF loading.
src/​utils/​getImagesFromPDF.ts Updates PDF rendering API.
src/​utils/​functions.ts Uses updated Konva typings.
src/​common/​constants.ts Safely handles optional stroke values.
package.json Updates dependencies and Node requirement.
pnpm-lock.yaml Locks upgraded dependency versions.
Files not reviewed (1)
  • pnpm-lock.yaml: Generated file

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/utils/pdfWorker.ts
@sebastianMindee
sebastianMindee requested a balanced review from Copilot October 2, 2026 12:54
@sebastianMindee sebastianMindee changed the title chg: ⬆️ update dependencies chg: ⬆️ update dependencies and add integration testing Oct 2, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Cache-busting only the entry module leaves the lazy PDF module shared, invalidating multiple worker lifecycle tests.

Review effort: Balanced
Findings: 3 Medium severity

Open (3)
Resolved since last review (1)
Files not reviewed (1)
  • pnpm-lock.yaml: Generated file

Comment thread cypress/integration/helpers.ts
Comment thread cypress/integration/lens.spec.tsx Outdated
Comment thread cypress/integration/viewer.spec.tsx Outdated
@sebastianMindee
sebastianMindee merged commit e779b5e into build-chain Oct 2, 2026
4 checks passed
@sebastianMindee sebastianMindee mentioned this pull request Oct 8, 2026
11 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants