Repository navigation
⚰️ remove dead v1 products and workflow methods - #274
Open
sebastianMindee wants to merge 6 commits into
Open
sebastianMindee wants to merge 6 commits into
sebastianMindee wants to merge 6 commits into
Conversation
sebastianMindee
requested review from
ianardee
and
a balanced review from Copilot
October 27, 2026 15:26
There was a problem hiding this comment.
🟢 Approval recommended
Static review found no dangling references or blocking defects, and shared image extraction retains existing test coverage.
No open issues 🎉
What changed in this PR
Removes retired Barcode Reader V1, French ID Card V1, and French Bank Account Details V1 products from the Ruby SDK while retaining newer supported versions.
Changes:
- Deletes retired product implementations and matching type signatures.
- Removes their examples and specs, including the barcode-dependent image extraction spec.
- Updates product loading and the CLI registry to omit removed products.
| File | Description |
|---|---|
spec/v1/product/fr/id_card_v1_spec.rb |
Removes ID Card V1 specs. |
spec/v1/product/fr/bank_account_details_v1_spec.rb |
Removes Bank Account Details V1 specs. |
spec/v1/product/barcode_reader_v1_spec.rb |
Removes Barcode Reader V1 specs. |
spec/image/image_extractor_spec.rb |
Removes barcode-dependent extraction specs. |
sig/mindee/v1/product/fr/id_card/id_card_v1.rbs |
Removes ID Card V1 inference signature. |
sig/mindee/v1/product/fr/id_card/id_card_v1_page.rbs |
Removes ID Card V1 page signatures. |
sig/mindee/v1/product/fr/id_card/id_card_v1_document.rbs |
Removes ID Card V1 document signature. |
sig/mindee/v1/product/fr/bank_account_details/bank_account_details_v1.rbs |
Removes Bank Account Details V1 inference signature. |
sig/mindee/v1/product/fr/bank_account_details/bank_account_details_v1_page.rbs |
Removes Bank Account Details V1 page signatures. |
sig/mindee/v1/product/fr/bank_account_details/bank_account_details_v1_document.rbs |
Removes Bank Account Details V1 document signature. |
sig/mindee/v1/product/barcode_reader/barcode_reader_v1.rbs |
Removes Barcode Reader V1 inference signature. |
sig/mindee/v1/product/barcode_reader/barcode_reader_v1_page.rbs |
Removes Barcode Reader V1 page signatures. |
sig/mindee/v1/product/barcode_reader/barcode_reader_v1_document.rbs |
Removes Barcode Reader V1 document signature. |
lib/mindee/v1/product/fr/id_card/id_card_v1.rb |
Removes ID Card V1 inference implementation. |
lib/mindee/v1/product/fr/id_card/id_card_v1_page.rb |
Removes ID Card V1 page parsing. |
lib/mindee/v1/product/fr/id_card/id_card_v1_document.rb |
Removes ID Card V1 document parsing. |
lib/mindee/v1/product/fr/bank_account_details/bank_account_details_v1.rb |
Removes Bank Account Details V1 inference implementation. |
lib/mindee/v1/product/fr/bank_account_details/bank_account_details_v1_page.rb |
Removes Bank Account Details V1 page parsing. |
lib/mindee/v1/product/fr/bank_account_details/bank_account_details_v1_document.rb |
Removes Bank Account Details V1 document parsing. |
lib/mindee/v1/product/barcode_reader/barcode_reader_v1.rb |
Removes Barcode Reader V1 inference implementation. |
lib/mindee/v1/product/barcode_reader/barcode_reader_v1_page.rb |
Removes Barcode Reader V1 page parsing. |
lib/mindee/v1/product/barcode_reader/barcode_reader_v1_document.rb |
Removes Barcode Reader V1 document parsing. |
lib/mindee/v1/product.rb |
Removes retired product imports. |
docs/code_samples/idcard_fr_v1.txt |
Removes ID Card V1 example. |
docs/code_samples/barcode_reader_v1.txt |
Removes Barcode Reader V1 example. |
docs/code_samples/bank_account_details_v1.txt |
Removes Bank Account Details V1 example. |
bin/v1/products.rb |
Removes Barcode Reader CLI registration. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Types of changes