Skip to content

⚰️ remove dead v1 products and workflow methods - #274

Open
sebastianMindee wants to merge 6 commits into
mainfrom
remove-deprecated-products
Open

sebastianMindee wants to merge 6 commits into
mainfrom
remove-deprecated-products

Conversation

@sebastianMindee

Copy link
Copy Markdown
Collaborator

Description

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires a change to the official Guide documentation.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Static review found no dangling references or blocking defects, and shared image extraction retains existing test coverage.

No open issues 🎉

What changed in this PR

Removes retired Barcode Reader V1, French ID Card V1, and French Bank Account Details V1 products from the Ruby SDK while retaining newer supported versions.

Changes:

  • Deletes retired product implementations and matching type signatures.
  • Removes their examples and specs, including the barcode-dependent image extraction spec.
  • Updates product loading and the CLI registry to omit removed products.
File Description
spec/​v1/​product/​fr/​id_card_v1_spec.rb Removes ID Card V1 specs.
spec/​v1/​product/​fr/​bank_account_details_v1_spec.rb Removes Bank Account Details V1 specs.
spec/​v1/​product/​barcode_reader_v1_spec.rb Removes Barcode Reader V1 specs.
spec/​image/​image_extractor_spec.rb Removes barcode-dependent extraction specs.
sig/​mindee/​v1/​product/​fr/​id_card/​id_card_v1.rbs Removes ID Card V1 inference signature.
sig/​mindee/​v1/​product/​fr/​id_card/​id_card_v1_page.rbs Removes ID Card V1 page signatures.
sig/​mindee/​v1/​product/​fr/​id_card/​id_card_v1_document.rbs Removes ID Card V1 document signature.
sig/​mindee/​v1/​product/​fr/​bank_account_details/​bank_account_details_v1.rbs Removes Bank Account Details V1 inference signature.
sig/​mindee/​v1/​product/​fr/​bank_account_details/​bank_account_details_v1_page.rbs Removes Bank Account Details V1 page signatures.
sig/​mindee/​v1/​product/​fr/​bank_account_details/​bank_account_details_v1_document.rbs Removes Bank Account Details V1 document signature.
sig/​mindee/​v1/​product/​barcode_reader/​barcode_reader_v1.rbs Removes Barcode Reader V1 inference signature.
sig/​mindee/​v1/​product/​barcode_reader/​barcode_reader_v1_page.rbs Removes Barcode Reader V1 page signatures.
sig/​mindee/​v1/​product/​barcode_reader/​barcode_reader_v1_document.rbs Removes Barcode Reader V1 document signature.
lib/​mindee/​v1/​product/​fr/​id_card/​id_card_v1.rb Removes ID Card V1 inference implementation.
lib/​mindee/​v1/​product/​fr/​id_card/​id_card_v1_page.rb Removes ID Card V1 page parsing.
lib/​mindee/​v1/​product/​fr/​id_card/​id_card_v1_document.rb Removes ID Card V1 document parsing.
lib/​mindee/​v1/​product/​fr/​bank_account_details/​bank_account_details_v1.rb Removes Bank Account Details V1 inference implementation.
lib/​mindee/​v1/​product/​fr/​bank_account_details/​bank_account_details_v1_page.rb Removes Bank Account Details V1 page parsing.
lib/​mindee/​v1/​product/​fr/​bank_account_details/​bank_account_details_v1_document.rb Removes Bank Account Details V1 document parsing.
lib/​mindee/​v1/​product/​barcode_reader/​barcode_reader_v1.rb Removes Barcode Reader V1 inference implementation.
lib/​mindee/​v1/​product/​barcode_reader/​barcode_reader_v1_page.rb Removes Barcode Reader V1 page parsing.
lib/​mindee/​v1/​product/​barcode_reader/​barcode_reader_v1_document.rb Removes Barcode Reader V1 document parsing.
lib/​mindee/​v1/​product.rb Removes retired product imports.
docs/​code_samples/​idcard_fr_v1.txt Removes ID Card V1 example.
docs/​code_samples/​barcode_reader_v1.txt Removes Barcode Reader V1 example.
docs/​code_samples/​bank_account_details_v1.txt Removes Bank Account Details V1 example.
bin/​v1/​products.rb Removes Barcode Reader CLI registration.

Review effort: Balanced

@sebastianMindee sebastianMindee changed the title ⚰️ remove dead v1 products ⚰️ remove dead v1 products and workflow methods Oct 29, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants