Repository navigation
♻️ 🐛 fix circular imports and refactor internals - #411
Merged
Merged
Conversation
ianardee
requested changes
Jun 3, 2026
ianardee
left a comment
ianardee
left a comment
Contributor
There was a problem hiding this comment.
looks good but should also add get_simple_field, get_list_field, and get_object_field to InferenceFields class, and add unit tests for this (fields.get() should also be tested as is done currently)
ianardee
requested changes
Jun 3, 2026
sebO-S
force-pushed
the
fix-circular-imports
branch
from
June 3, 2026 15:27
0c87259 to
67eb871
Compare
sebO-S
changed the title
ianardee
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Types of changes