Skip to content

♻️ update deprecated syntaxes + add checks - #226

Merged
sebastianMindee merged 1 commit into
mainfrom
remove-deprecated-syntax
Oct 27, 2026
Merged

sebastianMindee merged 1 commit into
mainfrom
remove-deprecated-syntax

Conversation

@sebastianMindee

@sebastianMindee sebastianMindee commented Oct 27, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Addresses #225

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires a change to the official Guide documentation.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Removing the suppression exposes an unresolved TestingUtilities reference that causes PHPStan checks to fail.

1 open issue
What changed in this PR

This PR modernizes deprecated cURL usage in the PHP SDK and expands checks for deprecations.

Changes:

  • Removes curl_close() calls and simplifies response returns.
  • Runs static analysis on PHP 8.1 and 8.5.
  • Enables deprecation exceptions in PDF tests and removes a PHPStan suppression.
File Description
tests/​pdffeatures.xml Converts deprecations to exceptions in PDF tests.
src/​V2/​Http/​MindeeApiV2.php Removes cURL close calls and simplifies returns.
src/​V1/​Http/​BaseEndpoint.php Simplifies cURL response handling.
src/​Input/​UrlInputSource.php Removes cURL close calls during downloads.
src/​Dependency/​DependencyChecker.php Removes a PHPStan suppression for a test-helper call.
.github/​workflows/​_static-analysis.yml Adds a PHP 8.1/8.5 analysis matrix.

Review effort: Balanced

Comment thread src/Dependency/DependencyChecker.php Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The changes preserve HTTP request behavior and strengthen compatibility checks, with no identified blocking issues.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

@sebastianMindee
sebastianMindee merged commit 745dfef into main Oct 27, 2026
33 checks passed
@sebastianMindee
sebastianMindee deleted the remove-deprecated-syntax branch October 27, 2026 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants