Repository navigation
♻️ update deprecated syntaxes + add checks - #226
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Removing the suppression exposes an unresolved TestingUtilities reference that causes PHPStan checks to fail.
1 open issue
What changed in this PR
This PR modernizes deprecated cURL usage in the PHP SDK and expands checks for deprecations.
Changes:
- Removes
curl_close()calls and simplifies response returns. - Runs static analysis on PHP 8.1 and 8.5.
- Enables deprecation exceptions in PDF tests and removes a PHPStan suppression.
| File | Description |
|---|---|
tests/pdffeatures.xml |
Converts deprecations to exceptions in PDF tests. |
src/V2/Http/MindeeApiV2.php |
Removes cURL close calls and simplifies returns. |
src/V1/Http/BaseEndpoint.php |
Simplifies cURL response handling. |
src/Input/UrlInputSource.php |
Removes cURL close calls during downloads. |
src/Dependency/DependencyChecker.php |
Removes a PHPStan suppression for a test-helper call. |
.github/workflows/_static-analysis.yml |
Adds a PHP 8.1/8.5 analysis matrix. |
Review effort: Balanced
sebastianMindee
force-pushed
the
remove-deprecated-syntax
branch
from
October 27, 2026 15:09
efe004b to
816ac30
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Addresses #225
Types of changes