Repository navigation
Better rag - #447
Merged
Merged
Better rag#447
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Poll-count regressions and several unintended public API compatibility breaks remain unresolved.
7 open findings
What changed in this PR
Improves polling behavior, centralizes client logging/throttling, and generalizes V2 RAG document handling.
Changes:
- Adds shared client polling and logging infrastructure.
- Refactors RAG annotation construction and product routing.
- Reorganizes and updates unit/integration tests.
| File | Description |
|---|---|
.editorconfig |
Removes trailing blank line. |
src/Mindee/ClientOptions/BaseClient.cs |
Adds shared logging and polling throttling. |
src/Mindee/ClientOptions/BasePollingOptions.cs |
Removes retry-delay helper. |
src/Mindee/Exceptions/MindeeInputException.cs |
Clarifies documentation. |
src/Mindee/MindeeLogger.cs |
Marks logger as V1 legacy infrastructure. |
src/Mindee/V1/Client.cs |
Adopts BaseClient and revises polling. |
src/Mindee/V1/Parsing/Standard/DateField.cs |
Corrects structured logging placeholder. |
src/Mindee/V2/Client.cs |
Adopts shared logging and polling logic. |
src/Mindee/V2/ClientOptions/BaseAnnotationParameters.cs |
Improves constructor documentation. |
src/Mindee/V2/ClientOptions/BaseRagDocumentUploadParameters.cs |
Improves constructor documentation. |
src/Mindee/V2/Http/HttpApiV2.cs |
Updates API documentation and naming. |
src/Mindee/V2/Http/MindeeApiV2.cs |
Generalizes RAG routes by product slug. |
src/Mindee/V2/Product/Extraction/RagDocuments/AnnotatedDynamicField.cs |
Adds type-specific constructors. |
src/Mindee/V2/Product/Extraction/RagDocuments/AnnotatedDynamicFieldJsonConverter.cs |
Uses the new constructors. |
src/Mindee/V2/Product/Extraction/RagDocuments/AnnotatedListField.cs |
Requires list items during construction. |
src/Mindee/V2/Product/Extraction/RagDocuments/AnnotatedObjectField.cs |
Requires nested fields during construction. |
src/Mindee/V2/Product/Extraction/RagDocuments/ExtractionRagAnnotationResponse.cs |
Adds extraction product metadata. |
src/Mindee/V2/Product/Extraction/RagDocuments/Params/RagDocumentUploadParameters.cs |
Removes unused imports. |
src/Mindee/V2/Product/Extraction/RagDocuments/RagAnnotation.cs |
Adds annotation constructors. |
tests/Mindee.IntegrationTests/V2/Product/Extraction/RagDocumentsTest.cs |
Simplifies model identifier naming. |
tests/Mindee.UnitTests/ClientOptions/BaseClientTest.cs |
Tests shared polling throttling. |
tests/Mindee.UnitTests/V1/AsyncPollingOptionsTest.cs |
Removes obsolete delay assertions. |
tests/Mindee.UnitTests/V2/ClientOptions/PollingOptionsTest.cs |
Removes obsolete delay assertions. |
tests/Mindee.UnitTests/V2/Product/ClassificationTest.cs |
Renames response fixture helper. |
tests/Mindee.UnitTests/V2/Product/CropTest.cs |
Renames response fixture helper. |
tests/Mindee.UnitTests/V2/Product/Extraction/ExtractionParametersTest.cs |
Reorganizes parameter tests. |
tests/Mindee.UnitTests/V2/Product/Extraction/ExtractionResponseTest.cs |
Separates response tests and renames helper. |
tests/Mindee.UnitTests/V2/Product/Extraction/RagDocumentsTest.cs |
Verifies serialized annotation structure. |
tests/Mindee.UnitTests/V2/Product/OcrTest.cs |
Renames response fixture helper. |
tests/Mindee.UnitTests/V2/Product/SplitTest.cs |
Renames response fixture helper. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
sebastianMindee
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Types of changes