Repository navigation
Conversation
ianardee
requested review from
sebastianMindee
and
a balanced review from Copilot
October 9, 2026 08:33
There was a problem hiding this comment.
🟡 Changes recommended
The package version is already published, CLI documentation remains stale, and a public extraction overload loses its only test coverage.
2 open findings
What changed in this PR
Removes deprecated V1 Bank Check, Barcode Reader, and Payroll Check Register products from the SDK and CLI.
Changes:
- Removes legacy product models, tests, samples, and CLI commands.
- Aligns file-operation test names and namespaces.
- Removes obsolete V1 documentation samples.
| File | Description |
|---|---|
tests/Mindee.UnitTests/V1/Product/Us/PayrollCheckRegister/PayrollCheckRegisterV1Test.cs |
Removes payroll register tests. |
tests/Mindee.UnitTests/V1/Product/Us/BankCheck/BankCheckV1Test.cs |
Removes bank check tests. |
tests/Mindee.UnitTests/V1/Product/BarcodeReader/BarcodeReaderV1Test.cs |
Removes barcode reader tests. |
tests/Mindee.UnitTests/V1/FileOperations/MultiPageExtractionTest.cs |
Renames test and removes barcode extraction coverage. |
tests/Mindee.UnitTests/V1/FileOperations/InvoiceSplitterTest.cs |
Aligns namespace and class name. |
src/Mindee/V1/Product/Us/PayrollCheckRegister/PayrollCheckRegisterV1Tax.cs |
Removes payroll tax model. |
src/Mindee/V1/Product/Us/PayrollCheckRegister/PayrollCheckRegisterV1Payment.cs |
Removes payroll payment model. |
src/Mindee/V1/Product/Us/PayrollCheckRegister/PayrollCheckRegisterV1Earning.cs |
Removes payroll earning model. |
src/Mindee/V1/Product/Us/PayrollCheckRegister/PayrollCheckRegisterV1Document.cs |
Removes payroll document model. |
src/Mindee/V1/Product/Us/PayrollCheckRegister/PayrollCheckRegisterV1Deduction.cs |
Removes payroll deduction model. |
src/Mindee/V1/Product/Us/PayrollCheckRegister/PayrollCheckRegisterV1.cs |
Removes payroll endpoint type. |
src/Mindee/V1/Product/Us/BankCheck/BankCheckV1Page.cs |
Removes bank check page model. |
src/Mindee/V1/Product/Us/BankCheck/BankCheckV1Document.cs |
Removes bank check document model. |
src/Mindee/V1/Product/Us/BankCheck/BankCheckV1.cs |
Removes bank check endpoint type. |
src/Mindee/V1/Product/BarcodeReader/BarcodeReaderV1Document.cs |
Removes barcode document model. |
src/Mindee/V1/Product/BarcodeReader/BarcodeReaderV1.cs |
Removes barcode endpoint type. |
src/Mindee.Cli/Program.cs |
Removes corresponding CLI commands. |
docs/code_samples/payroll_check_register_v1_async.txt |
Removes payroll sample. |
docs/code_samples/idcard_fr_v1.txt |
Removes obsolete ID card V1 sample. |
docs/code_samples/barcode_reader_v1.txt |
Removes barcode sample. |
docs/code_samples/bank_check_v1.txt |
Removes bank check sample. |
docs/code_samples/bank_account_details_v1.txt |
Removes obsolete bank details V1 sample. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
sebastianMindee
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Types of changes