Repository navigation
Better polling - #445
Merged
Merged
Better polling#445
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Poll exhaustion waits unnecessarily after the final attempt, and the rewritten polling state machine lacks deterministic unit coverage.
Review effort: Balanced
Findings: 2
Open (3)
What changed in this PR
Refines V2 polling behavior, logging, documentation, and test naming.
Changes:
- Splits job polling from result retrieval and improves failure handling.
- Uses null logging by default and adjusts polling logs.
- Improves API documentation and test display names.
| File | Description |
|---|---|
src/Mindee/V2/Client.cs |
Refactors polling and logging behavior. |
src/Mindee/V2/Http/HttpApiV2.cs |
Documents the deletion parameter. |
tests/Mindee.UnitTests/V2/Product/Extraction/RagDocumentsTest.cs |
Adds descriptive test names. |
tests/Mindee.UnitTests/V2/Parsing/FailedInferenceResponseTest.cs |
Adds a descriptive test name. |
tests/Mindee.IntegrationTests/V2/Product/Extraction/RagDocumentsTest.cs |
Adds a descriptive lifecycle test name. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ianardee
force-pushed
the
better-polling
branch
4 times, most recently
from
October 6, 2026 19:17
f863da1 to
8513d3a
Compare
ianardee
force-pushed
the
better-polling
branch
from
October 7, 2026 08:07
8513d3a to
17866b1
Compare
sebastianMindee
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Types of changes