Repository navigation
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The added test assertion matches the current BaseLocalResponse behavior (newline stripping via ReadLine()), and the remaining changes are non-functional refactors/documentation tweaks.
Pull request overview
This PR strengthens the LocalResponse test suite by explicitly validating the ToString() output normalization (line endings removal), and does a small documentation wording tweak in BaseLocalResponse.
Changes:
- Add an assertion that
LocalResponse.ToString()matches the original JSON with\r/\nremoved (reflecting the canonicalization performed byBaseLocalResponse). - Refactor the V2 test to reuse a shared JSON path constant and reintroduce/relocate the buffer-based constructor test.
- Minor XML-doc wording update for
ReadToCleanUtf8Bytes.
File summaries
| File | Description |
|---|---|
| tests/Mindee.UnitTests/V2/Parsing/LocalResponseTest.cs | Adds ToString() normalization assertion and refactors/reorders constructor-coverage tests. |
| src/Mindee/Parsing/BaseLocalResponse.cs | Updates method summary wording (no behavioral change). |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
🟢 Approval recommended
The added assertions and minor refactors align with the current BaseLocalResponse behavior (line-ending removal + leaveOpen: true stream handling) and should be low-risk.
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0 new
- Review effort level: Lite
Description
Types of changes