Repository navigation
[utils] Return exactly num_colors colors from get_colors - #2190
Merged
felixdittrich92 merged 1 commit intoOct 30, 2026
Merged
Conversation
felixdittrich92
approved these changes
Oct 29, 2026
felixdittrich92
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @RavSinghChandan 👍
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2190 +/- ##
=======================================
Coverage 97.75% 97.75%
=======================================
Files 170 170
Lines 10959 10959
=======================================
Hits 10713 10713
Misses 246 246
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_colorsstepped through the hues withnp.arange(0.0, 360.0, 360.0 / num_colors). A float step can include one more value, close to 360°, soget_colors(161)returned 162 colors (the last one is red again, like the first), andget_colors(0)raisedZeroDivisionError. The layout views work around the zero case withmax(len(region_classes), 1), butvisualize_kie_pagedoes not, so a KIE page without any prediction class failed to render.The hues now come from an integer range (
i / num_colors), which gives exactlynum_colorscolors, and none for 0. For other counts the hues are the same as before