Repository navigation
feat: add Amiga custom register bitfield auto-comments and call-graph cycle propagation - #5
Merged
Merged
Conversation
… cycle propagation - Decode immediate .w and paired .l writes to DMACON, INTENA, INTREQ, ADKCON, BPLCON0, BLTCON0, BLTCON1, and BLTSIZE into persistent auto-comments that survive emit - Propagate self and inclusive (+callees) MC68000 cycle bounds (+loop, +ind) across the static call graph (hunks cg) - Surface inclusive subroutine cycle bounds in TUI v/V selection status bar, jsr/bsr callee timing hints, and the Functions (f) modal - Fix labels.type column name in FunctionLabelAddrs()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
internal/amiga/bitfields.go,internal/analyzer/format.go,internal/analyzer/baseregs.go):.wand paired.lwrites to key Amiga custom registers (DMACON,INTENA,INTREQ,ADKCON,BPLCON0,BLTCON0,BLTCON1,BLTSIZE) into human-readable bitfield auto-comments stored incomments.auto_commentso they appear in the TUI and survivehunks emitinto.asmfiles.internal/callgraph/callgraph.go,internal/tui/):min-max cyc) and Inclusive (+callees) cycle bounds (plus+loopand+indmarkers) across the static call graph (hunks cg).[incl: X-Y cyc]in the TUIv/Vselection status bar,[→X-Y cyc]callee timing hints when the cursor is on ajsr/bsrinstruction, and self/inclusive cycle summaries in the Functions (f) modal.l.kind->l.typecolumn name inFunctionLabelAddrs().Test Plan
go build ./... && go vet ./... && go test -v ./...internal/amiga/bitfields_test.go,internal/analyzer/analyzer_test.go,internal/callgraph/callgraph_test.go, andinternal/tui/tui_test.go.