Repository navigation
test(publisher): read eventPrefix in Upstash publisher tests - #2336
Conversation
The protected prefix field was renamed to eventPrefix in #2332, so the tests read the new prefix() method instead and failed.
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Upstash publisher test prefix reads — two test assertions now read the renamed
eventPrefixprotected field instead of the oldprefixfield, restoring the stream-key and channel lookups.
Verified against the source: BaseRedisPublisher declares protected readonly eventPrefix: string (set from prefix ?? ''), and UpstashPublisher.prefix() is now the method. The remaining prefix references in the test are local variables and option literals, correctly left untouched. Test-only, no production behavior change.
deepseek-v4.1-flash (free via Pullfrog for OSS) | 𝕏
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
orpc | e103c8e | Commit Preview URL Branch Preview URL |
Oct 25 2026, 02:39 AM |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
More templates
@orpc/ai-sdk
@orpc/arktype
@orpc/bun
@orpc/client
@orpc/cloudflare
@orpc/contract
@orpc/effect
@orpc/evlog
@orpc/hibernation
@orpc/json-schema
@orpc/experimental-lock
@orpc/mcp
@orpc/msw
@orpc/nest
@orpc/next
@orpc/node
@orpc/openapi
@orpc/opentelemetry
@orpc/pinia-colada
@orpc/pino
@orpc/publisher
@orpc/ratelimit
@orpc/server
@orpc/shared
@orpc/swr
@orpc/tanstack-query
@orpc/trpc
@orpc/valibot
@orpc/zod
commit: |
Merging this PR will not alter performance1 warning
Comparing Footnotes
|

The Upstash publisher tests have been failing since #2332 renamed the protected
prefixfield toeventPrefix. The tests still readprefix, which now returns the newprefix()method, so they looked up the wrong Redis keys and channels.Fixes
afterAllcleanup check passes again.Testing