Skip to content

test(publisher): read eventPrefix in Upstash publisher tests - #2336

Merged
dinwwwh merged 1 commit into
mainfrom
claude/fix-upstash-publisher-tests
Oct 25, 2026
Merged

dinwwwh merged 1 commit into
mainfrom
claude/fix-upstash-publisher-tests

Conversation

@dinwwwh

@dinwwwh dinwwwh commented Oct 25, 2026

Copy link
Copy Markdown
Member

The Upstash publisher tests have been failing since #2332 renamed the protected prefix field to eventPrefix. The tests still read prefix, which now returns the new prefix() method, so they looked up the wrong Redis keys and channels.

Fixes

  • "supports custom serializers and custom prefixes" finds its stream key again.
  • "does not crash if teardown runs after internal maps were already pruned" finds its subscription and cleans it up, so the suite-wide afterAll cleanup check passes again.

Testing

  • Publisher, rate limiter, and lock Upstash suites pass locally against a real Upstash server (39/39).

The protected prefix field was renamed to eventPrefix in #2332, so the tests read the new prefix() method instead and failed.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

  • Upstash publisher test prefix reads — two test assertions now read the renamed eventPrefix protected field instead of the old prefix field, restoring the stream-key and channel lookups.

Verified against the source: BaseRedisPublisher declares protected readonly eventPrefix: string (set from prefix ?? ''), and UpstashPublisher.prefix() is now the method. The remaining prefix references in the test are local variables and option literals, correctly left untouched. Test-only, no production behavior change.

Pullfrog  | View workflow run | Using deepseek-v4.1-flash (free via Pullfrog for OSS) | 𝕏

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
orpc e103c8e Commit Preview URL

Branch Preview URL
Oct 25 2026, 02:39 AM

@codecov

codecov Bot commented Oct 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@pkg-pr-new

pkg-pr-new Bot commented Oct 25, 2026

Copy link
Copy Markdown
More templates

@orpc/ai-sdk

npm i https://pkg.pr.new/@orpc/ai-sdk@2336

@orpc/arktype

npm i https://pkg.pr.new/@orpc/arktype@2336

@orpc/bun

npm i https://pkg.pr.new/@orpc/bun@2336

@orpc/client

npm i https://pkg.pr.new/@orpc/client@2336

@orpc/cloudflare

npm i https://pkg.pr.new/@orpc/cloudflare@2336

@orpc/contract

npm i https://pkg.pr.new/@orpc/contract@2336

@orpc/effect

npm i https://pkg.pr.new/@orpc/effect@2336

@orpc/evlog

npm i https://pkg.pr.new/@orpc/evlog@2336

@orpc/hibernation

npm i https://pkg.pr.new/@orpc/hibernation@2336

@orpc/json-schema

npm i https://pkg.pr.new/@orpc/json-schema@2336

@orpc/experimental-lock

npm i https://pkg.pr.new/@orpc/experimental-lock@2336

@orpc/mcp

npm i https://pkg.pr.new/@orpc/mcp@2336

@orpc/msw

npm i https://pkg.pr.new/@orpc/msw@2336

@orpc/nest

npm i https://pkg.pr.new/@orpc/nest@2336

@orpc/next

npm i https://pkg.pr.new/@orpc/next@2336

@orpc/node

npm i https://pkg.pr.new/@orpc/node@2336

@orpc/openapi

npm i https://pkg.pr.new/@orpc/openapi@2336

@orpc/opentelemetry

npm i https://pkg.pr.new/@orpc/opentelemetry@2336

@orpc/pinia-colada

npm i https://pkg.pr.new/@orpc/pinia-colada@2336

@orpc/pino

npm i https://pkg.pr.new/@orpc/pino@2336

@orpc/publisher

npm i https://pkg.pr.new/@orpc/publisher@2336

@orpc/ratelimit

npm i https://pkg.pr.new/@orpc/ratelimit@2336

@orpc/server

npm i https://pkg.pr.new/@orpc/server@2336

@orpc/shared

npm i https://pkg.pr.new/@orpc/shared@2336

@orpc/swr

npm i https://pkg.pr.new/@orpc/swr@2336

@orpc/tanstack-query

npm i https://pkg.pr.new/@orpc/tanstack-query@2336

@orpc/trpc

npm i https://pkg.pr.new/@orpc/trpc@2336

@orpc/valibot

npm i https://pkg.pr.new/@orpc/valibot@2336

@orpc/zod

npm i https://pkg.pr.new/@orpc/zod@2336

commit: e103c8e

@codspeed

codspeed Bot commented Oct 25, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

1 warning

⚠️ 6 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

✅ 28 untouched benchmarks
⏩ 2 skipped benchmarks1


Comparing claude/fix-upstash-publisher-tests (e103c8e) with main (4b17964)

Open in CodSpeed

Footnotes

  1. 2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@dinwwwh
dinwwwh merged commit 00bfdba into main Oct 25, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant