Skip to content

build(types): keep tsc -b output out of dist - #98

Closed
dinwwwh wants to merge 1 commit into
mainfrom
claude/project-thread-rxkexr
Closed

dinwwwh wants to merge 1 commit into
mainfrom
claude/project-thread-rxkexr

Conversation

@dinwwwh

@dinwwwh dinwwwh commented Oct 24, 2026

Copy link
Copy Markdown
Member

Requested by dinwwwh · project thread

pnpm run check runs tsc -b packages/downgrader/tsconfig.json, which also builds the referenced packages/types project. That project had no outDir, so it wrote src/*.d.ts, src/*.d.ts.map and tsconfig.tsbuildinfo into packages/types/dist, which is the folder unbuild publishes.

This change gives packages/types/tsconfig.json the same tsBuildInfoFile / outDir: "out" override that the downgrader already has. out/ is already gitignored.

Published tarballs were not affected. prepack runs unbuild, which wipes dist first, and the release job doesn't run check. The problem only showed up locally: after a pnpm run check, dist held a mix of tsc and unbuild output.

Checked locally

  • On main: pnpm run check creates packages/types/dist/src/*.d.ts{,.map} and dist/tsconfig.tsbuildinfo.
  • On this branch, starting from a clean tree: pnpm run check passes and writes only to packages/types/out/; dist is never created.
  • unbuild in packages/types followed by pnpm run check: dist holds only v3.{0,1,2}.{mjs,d.mts}.
  • pnpm test: 262 passed.

Generated by Claude Code

`pnpm run check` runs `tsc -b packages/downgrader/tsconfig.json`, which
also builds the referenced types project. Without an override, that
project emitted `.d.ts`, `.d.ts.map` and `tsconfig.tsbuildinfo` into
`packages/types/dist`, unbuild's publish folder. Mirror the downgrader
and send them to the gitignored `out/` instead.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NLn5bDFeN1aE2QDjKkSmsv
@dinwwwh dinwwwh self-assigned this Oct 24, 2026
@codecov

codecov Bot commented Oct 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@codspeed

codspeed Bot commented Oct 24, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 21 untouched benchmarks


Comparing claude/project-thread-rxkexr (b119eb5) with main (6a906e9)

Open in CodSpeed

@dinwwwh dinwwwh closed this Oct 24, 2026

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes
Reviewed the single-file build-config change on b119eb5, including pnpm run check, pnpm run prepack (unbuild), and pnpm test.

  • Build output relocation: Added tsBuildInfoFile: "out/.tsbuildinfo" and outDir: "out" to packages/types/tsconfig.json, mirroring packages/downgrader/tsconfig.json, so tsc -b writes declarations to out/ instead of the published dist/.

Pullfrog  | View workflow run | Using deepseek-v4.1-flash (free via Pullfrog for OSS) | 𝕏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants