Repository navigation
Conversation
`pnpm run check` runs `tsc -b packages/downgrader/tsconfig.json`, which also builds the referenced types project. Without an override, that project emitted `.d.ts`, `.d.ts.map` and `tsconfig.tsbuildinfo` into `packages/types/dist`, unbuild's publish folder. Mirror the downgrader and send them to the gitignored `out/` instead. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NLn5bDFeN1aE2QDjKkSmsv
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
Reviewed the single-file build-config change on b119eb5, including pnpm run check, pnpm run prepack (unbuild), and pnpm test.
- Build output relocation: Added
tsBuildInfoFile: "out/.tsbuildinfo"andoutDir: "out"topackages/types/tsconfig.json, mirroringpackages/downgrader/tsconfig.json, sotsc -bwrites declarations toout/instead of the publisheddist/.
deepseek-v4.1-flash (free via Pullfrog for OSS) | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Requested by dinwwwh · project thread
pnpm run checkrunstsc -b packages/downgrader/tsconfig.json, which also builds the referencedpackages/typesproject. That project had nooutDir, so it wrotesrc/*.d.ts,src/*.d.ts.mapandtsconfig.tsbuildinfointopackages/types/dist, which is the folder unbuild publishes.This change gives
packages/types/tsconfig.jsonthe sametsBuildInfoFile/outDir: "out"override that the downgrader already has.out/is already gitignored.Published tarballs were not affected.
prepackruns unbuild, which wipesdistfirst, and the release job doesn't run check. The problem only showed up locally: after apnpm run check,distheld a mix of tsc and unbuild output.Checked locally
main:pnpm run checkcreatespackages/types/dist/src/*.d.ts{,.map}anddist/tsconfig.tsbuildinfo.pnpm run checkpasses and writes only topackages/types/out/;distis never created.unbuildinpackages/typesfollowed bypnpm run check:distholds onlyv3.{0,1,2}.{mjs,d.mts}.pnpm test: 262 passed.Generated by Claude Code