Repository navigation
Conversation
…rsion Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Doek2EaqL6pLLJEyYo6FDr
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes — docs-only PR, no behavioral surface. I verified every factual claim in the added text against the source, the published OAS versions, and oRPC's source.
- JSDoc on the four converter exports — the two spec functions name the
openapithey set (3.0.4atv3.1-to-v3.0.ts:788,3.1.2atv3.2-to-v3.1.ts:300), matching eachfinishDocument.downgradeSchemaV31ToV30's "local$refs resolve against the schema itself" holds:convertSchemaRef→inline→resolvePointer(ref, ctx)→find(ctx.root, ref)withroot = schema.downgradeSchemaV32ToV31correctly omits any such note, since itsconvertSchemais a plainconvertObjectand passes$refthrough. - README output-version sentence (
README.md:58) —3.1.2(2025-09-19) and3.0.4(2024-10-24) are indeed the latest patches of their lines per the spec's version list, and "as oRPC does" checks out:toVersionedOpenAPIDocumentin oRPC'sopenapi-generator.tsdowngrades then returns{ ...downgraded, openapi: version }.
uncheck on the three touched files passes (oxlint, oxfmt, tsc).
deepseek-v4.1-flash (free via Pullfrog for OSS) | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Requested by dinwwwh · project thread
Docs only, no behavior change.
downgradeSpecV31ToV30,downgradeSchemaV31ToV30,downgradeSpecV32ToV31, anddowngradeSchemaV32ToV31, so editors show what each does on hover. The spec functions name theopenapithey set (3.0.4and3.1.2, from eachfinishDocument). The 3.1 to 3.0 schema function notes that local$refs resolve against the schema itself; the 3.2 to 3.1 schema function resolves no schema$refs, so its JSDoc doesn't say so.openapiis the latest patch release,3.1.2or3.0.4, and callers who want another patch release set it afterwards, as oRPC does.pnpm run checkandpnpm test(262 tests) pass locally.Generated by Claude Code