Skip to content

refactor(downgrader): drop the unreachable isRecord check on anyOf targets #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dinwwwh merged 1 commit into from
Oct 24, 2026
Merged

refactor(downgrader): drop the unreachable isRecord check on anyOf targets #95

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions packages/downgrader/src/v3.1-to-v3.0.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ const twoBranchAnyOfs: [schema: Record<string, unknown>, input: object][] = []

// Input schemas whose `anyOf` a `$ref` kept as written points into. They keep
// it, so the `$ref` still resolves.
const anyOfTargets = new Set<object>()
const anyOfTargets = new Set<unknown>()

// A branch with these stays: null can still fail them beside `nullable: true`,
// and a `nullable` already there was written 3.0-style.
Expand Down Expand Up @@ -280,10 +280,7 @@ function refOr(convert: Convert): Convert {
function convertSchemaRef(ref: string, ctx: Context): unknown {
if (!isInlined(ref, ctx)) {
for (let at = ref.indexOf('/anyOf/'); at !== -1; at = ref.indexOf('/anyOf/', at + 1)) {
const holder = resolvePointer(ref.slice(0, at), ctx)
if (isRecord(holder)) {
anyOfTargets.add(holder)
}
anyOfTargets.add(resolvePointer(ref.slice(0, at), ctx))
}
// A `$ref` kept as written loses what its target loses. Converting the
// target here reuses the copy the components get, and stops at a cycle.
Expand Down
Loading