Skip to content

docs(downgrader): note that a mutualTLS-only security list is removed in 3.1 to 3.0 - #91

Merged
dinwwwh merged 1 commit into
mainfrom
claude/project-thread-hhhrxt
Oct 24, 2026
Merged

dinwwwh merged 1 commit into
mainfrom
claude/project-thread-hhhrxt

Conversation

@dinwwwh

@dinwwwh dinwwwh commented Oct 24, 2026

Copy link
Copy Markdown
Member

Requested by dinwwwh · project thread

Docs only, no behavior change.

convertSecurity removes a security list left empty once mutualTLS schemes are dropped. The README limitation covered only the operation case (it falls back to the document's security). This extends it to the document case too: a document security that lists only mutual TLS alternatives is removed, so 3.0 requires no security.

It also rewords the convertSecurity comment, which said removing an emptied list avoids meaning "no security is needed". That only holds for an operation; at the document level a removed list and [] both mean no security. The existing test drops their names from security requirements, then emptied requirements and lists already covers both cases.


Generated by Claude Code

… in 3.1 to 3.0

An operation's list then falls back to the document's security, and the
document's own list leaves no security required. Reword the convertSecurity
comment, which said removing a list avoids "no security is needed".

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01J3j7B1BpNEjm9ct3FPQTBD
@dinwwwh dinwwwh self-assigned this Oct 24, 2026
@codecov

codecov Bot commented Oct 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

  • README limitation reworded — the mutualTLS security-list bullet now covers both scopes: an operation falls back to the document's security, and a document list left with nothing means no security is required.
  • convertSecurity comment reworded — distinguishes why an emptied requirement is removed (an empty requirement means optional security) from why an emptied list is removed (operation fallback).

Both claims match convertSecurity (packages/downgrader/src/v3.1-to-v3.0.ts:749) and are already pinned by the existing test packages/downgrader/tests/v3.1-to-v3.0.test.ts:260, which asserts the document list is removed and that each operation case (dropped list, kept {}, preserved []) behaves as described. uncheck passes on both changed files.

Pullfrog  | View workflow run | Using deepseek-v4.1-flash (free via Pullfrog for OSS) | 𝕏

@codspeed

codspeed Bot commented Oct 24, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 21 untouched benchmarks


Comparing claude/project-thread-hhhrxt (5ea95bb) with main (ae7568d)

Open in CodSpeed

@dinwwwh
dinwwwh merged commit c716716 into main Oct 24, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants