Repository navigation
docs(downgrader): note that a mutualTLS-only security list is removed in 3.1 to 3.0 - #91
Merged
Merged
Conversation
… in 3.1 to 3.0 An operation's list then falls back to the document's security, and the document's own list leaves no security required. Reword the convertSecurity comment, which said removing a list avoids "no security is needed". Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J3j7B1BpNEjm9ct3FPQTBD
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- README limitation reworded — the mutualTLS security-list bullet now covers both scopes: an operation falls back to the document's
security, and a document list left with nothing means no security is required. convertSecuritycomment reworded — distinguishes why an emptied requirement is removed (an empty requirement means optional security) from why an emptied list is removed (operation fallback).
Both claims match convertSecurity (packages/downgrader/src/v3.1-to-v3.0.ts:749) and are already pinned by the existing test packages/downgrader/tests/v3.1-to-v3.0.test.ts:260, which asserts the document list is removed and that each operation case (dropped list, kept {}, preserved []) behaves as described. uncheck passes on both changed files.
deepseek-v4.1-flash (free via Pullfrog for OSS) | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Requested by dinwwwh · project thread
Docs only, no behavior change.
convertSecurityremoves asecuritylist left empty oncemutualTLSschemes are dropped. The README limitation covered only the operation case (it falls back to the document'ssecurity). This extends it to the document case too: a documentsecuritythat lists only mutual TLS alternatives is removed, so 3.0 requires no security.It also rewords the
convertSecuritycomment, which said removing an emptied list avoids meaning "no security is needed". That only holds for an operation; at the document level a removed list and[]both mean no security. The existing testdrops their names from security requirements, then emptied requirements and listsalready covers both cases.Generated by Claude Code