Skip to content

test(downgrader): cover rejectsNull and null branch checks in 3.1 to 3.0 nullable merge #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dinwwwh merged 1 commit into from
Oct 24, 2026
Merged

test(downgrader): cover rejectsNull and null branch checks in 3.1 to 3.0 nullable merge #90

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions packages/downgrader/tests/v3.1-to-v3.0.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,6 +500,7 @@ describe('downgradeSchemaV31ToV30', () => {
{ type: 'string', enum: ['a', 'b'] },
{ type: 'object', allOf: [{ required: ['a'] }] },
{ type: 'integer', not: { const: 0 } },
{ type: 'string', oneOf: [{ minLength: 1 }, { maxLength: 0 }] },
]
for (const branch of typed) {
expect(downgradeSchemaV31ToV30({ anyOf: [branch, { type: 'null' }] })).toEqual({
Expand Down Expand Up @@ -536,6 +537,12 @@ describe('downgradeSchemaV31ToV30', () => {
anyOf: [{ type: 'string' }, { type: 'null' }, { type: 'null' }],
}),
).toEqual({ anyOf: [{ type: 'string' }, onlyNull, onlyNull] })
// A null branch with more than its type is not only null.
expect(
downgradeSchemaV31ToV30({
anyOf: [{ type: 'object' }, { type: 'null', description: 'd' }],
}),
).toEqual({ anyOf: [{ type: 'object' }, { ...onlyNull, description: 'd' }] })
})

it('makes an anyOf of a $ref and null a oneOf when the target rejects null', () => {
Expand All @@ -552,9 +559,15 @@ describe('downgradeSchemaV31ToV30', () => {
expect(pet({ type: 'object' })).toEqual({
oneOf: [{ $ref: '#/components/schemas/Pet' }, onlyNull],
})
expect(pet({ type: ['object', 'string'] })).toEqual({
oneOf: [{ $ref: '#/components/schemas/Pet' }, onlyNull],
})
expect(pet({ type: ['object', 'null'] })).toEqual({
anyOf: [{ $ref: '#/components/schemas/Pet' }, onlyNull],
})
expect(pet({ type: 'null' })).toEqual({
anyOf: [{ $ref: '#/components/schemas/Pet' }, onlyNull],
})
expect(pet({ type: 'object', nullable: true } as OpenAPIV3_1.SchemaObject)).toEqual({
anyOf: [{ $ref: '#/components/schemas/Pet' }, onlyNull],
})
Expand Down
Loading