Skip to content

perf(downgrader): skip decoding and unescaping plain $refs, fast path plain objects #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dinwwwh merged 1 commit into from
Oct 24, 2026
Merged

perf(downgrader): skip decoding and unescaping plain $refs, fast path plain objects #85

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/downgrader/src/shared.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ export function isRecord(value: unknown): value is Record<string, unknown> {
const proto: unknown = Object.getPrototypeOf(value)
return (
proto === null ||
proto === Object.prototype ||
(Object.getPrototypeOf(proto) === null && Object.keys(proto as object).length === 0)
)
}
Expand Down Expand Up @@ -192,7 +193,7 @@ function find(root: unknown, ref: string): unknown {
}
let pointer: string
try {
pointer = decodeURIComponent(ref.slice(1))
pointer = ref.includes('%') ? decodeURIComponent(ref.slice(1)) : ref.slice(1)
} catch {
return undefined
}
Expand All @@ -201,7 +202,7 @@ function find(root: unknown, ref: string): unknown {
}
let target = root
for (const token of pointer.split('/').slice(1)) {
const key = token.replaceAll('~1', '/').replaceAll('~0', '~')
const key = token.includes('~') ? token.replaceAll('~1', '/').replaceAll('~0', '~') : token
if (!(isRecord(target) || Array.isArray(target)) || !Object.hasOwn(target, key)) {
return undefined
}
Expand Down
Loading