[dinwwwh]

Requested by dinwwwh · project thread

Test-only follow-up to #79 and #80. #79 checked the withUndefined twin of the oRPC document only for the 3.2 to 3.1 step, because 3.1 to 3.0 counted keys holding undefined. #80 fixed that, so the 3.0 twin test now runs over both nullPrototype and withUndefined.

The new case fails on the commit before #80 and passes on main.

---

Generated by Claude Code

[macroscopeapp]

Approvability

Verdict: Approved at f252dcb

Macroscope's review found this PR approvable — This change only extends an existing downgrader test to cover the undefined-key variant for 3.0, with no production code or runtime behavior changes. The impact is confined to test execution.

Notes:

• No code objects were reviewed. Approvability was decided on eligibility alone.

^{You can add or adjust custom eligibility rules. Learn more.}

[codspeed]

Merging this PR will not alter performance

✅ 21 untouched benchmarks

---

_{Comparing claude/project-thread-6ztq09 (f252dcb) with main (7cd17bc)}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[pullfrog]

✅ No new issues found.

Reviewed changes

• Generalized the 3.0 oRPC test to it.each — the 3.1→3.0 twin now runs over both nullPrototype and withUndefined, matching the 3.2→3.1 twin already added in #79. The only change to the assertion body is parameterizing the rebuild(v31, object) argument; the plain comparison target is unchanged.

I confirmed the new case is genuinely falsifiable rather than tautological: reverting the two fixes from #80 in src/v3.1-to-v3.0.ts (the isMediaTypeOnly key-count check and the losesRestriction propertyNames check) makes the withUndefined case fail, and it passes on current main. vitest run packages/downgrader/tests/orpc.test.ts is green (7 tests), and uncheck reports oxlint/oxfmt/tsc clean on the touched file.

  ^{｜ View workflow run ｜ Using deepseek-v4.1-flash (free via Pullfrog for OSS) ｜ 𝕏}