Repository navigation
Angular 21: merge angular19 into master - #2145
Merged
Merged
Conversation
PR CI checks out the frontend (and sibling plugins) at the branch the PR targets instead of always stable. Corepack is enabled before every yarn install, since the frontend's angular19 branch pins yarn@4; the Docker build uses yarn for the frontend build as well. Dead WDIO config copies are dropped (the frontend no longer has WDIO). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…lar 21 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…exists) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ervices Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…vide it Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Angular 21: standalone components, Vitest and angular19 CI
There was a problem hiding this comment.
🔵 Needs a closer look
The cross-repository migration needs human confirmation of runtime compatibility and CI results against the frontend’s updated master branch.
No open issues 🎉
What changed in this PR
Moves the plugin’s Angular 21 implementation into master, aligning it with the frontend migration.
Changes:
- Converts components to standalone imports and simplifies feature modules.
- Migrates specs to Vitest and updates row identifiers and test selectors.
- Adds Angular unit-test jobs, matching frontend branches, and Corepack support.
| File | Description |
|---|---|
| eform-client/src/app/plugins/modules/items-planning-pn/modules/plannings/plannings.module.ts | Imports standalone planning components. |
| eform-client/src/app/plugins/modules/items-planning-pn/modules/plannings/components/plannings-page/plannings-table/plannings-table.component.ts | Adds standalone table dependencies. |
| eform-client/src/app/plugins/modules/items-planning-pn/modules/plannings/components/plannings-page/plannings-table/plannings-table.component.html | Updates chips and indexes tag IDs. |
| eform-client/src/app/plugins/modules/items-planning-pn/modules/plannings/components/plannings-page/plannings-header/plannings-header.component.ts | Adds standalone header dependencies. |
| eform-client/src/app/plugins/modules/items-planning-pn/modules/plannings/components/plannings-page/plannings-header/plannings-header.component.spec.ts | Migrates header setup to Vitest. |
| eform-client/src/app/plugins/modules/items-planning-pn/modules/plannings/components/plannings-page/plannings-container/plannings-container.component.ts | Imports standalone child components. |
| eform-client/src/app/plugins/modules/items-planning-pn/modules/plannings/components/planning-additions/plannings-bulk-import-modal/plannings-bulk-import-modal.component.ts | Adds standalone import-dialog dependencies. |
| eform-client/src/app/plugins/modules/items-planning-pn/modules/plannings/components/planning-additions/plannings-bulk-import-modal/plannings-bulk-import-modal.component.spec.ts | Adds Vitest setup and service mocks. |
| eform-client/src/app/plugins/modules/items-planning-pn/modules/plannings/components/planning-additions/planning-tags/planning-tags.component.ts | Enables standalone tags and guards dialog updates. |
| eform-client/src/app/plugins/modules/items-planning-pn/modules/plannings/components/planning-additions/planning-folders-modal/planning-folders-modal.component.ts | Adds standalone folder-dialog dependencies. |
| eform-client/src/app/plugins/modules/items-planning-pn/modules/plannings/components/planning-additions/planning-folders-modal/planning-folders-modal.component.spec.ts | Corrects tested component and adopts Vitest. |
| eform-client/src/app/plugins/modules/items-planning-pn/modules/plannings/components/planning-actions/planning-multiple-delete/planning-multiple-delete.component.ts | Adds standalone bulk-delete dependencies. |
| eform-client/src/app/plugins/modules/items-planning-pn/modules/plannings/components/planning-actions/planning-edit/planning-edit.component.ts | Adds standalone editing dependencies. |
| eform-client/src/app/plugins/modules/items-planning-pn/modules/plannings/components/planning-actions/planning-delete/planning-delete.component.ts | Adds standalone delete-dialog dependencies. |
| eform-client/src/app/plugins/modules/items-planning-pn/modules/plannings/components/planning-actions/planning-create/planning-create.component.ts | Adds standalone creation dependencies. |
| eform-client/src/app/plugins/modules/items-planning-pn/modules/plannings/components/planning-actions/planning-assign-sites-modal/planning-assign-sites-modal.component.ts | Adds standalone site-assignment dependencies. |
| eform-client/src/app/plugins/modules/items-planning-pn/modules/pairing/pairing.module.ts | Imports standalone pairing components. |
| eform-client/src/app/plugins/modules/items-planning-pn/modules/pairing/components/pairing-grid-update/pairing-grid-update.component.ts | Adds standalone update-dialog dependencies. |
| eform-client/src/app/plugins/modules/items-planning-pn/modules/pairing/components/pairing-grid-update/pairing-grid-update.component.spec.ts | Migrates to Vitest and tests pairing classification. |
| eform-client/src/app/plugins/modules/items-planning-pn/modules/pairing/components/pairing-grid-table/pairing-grid-table.component.ts | Adds standalone pairing-table dependencies. |
| eform-client/src/app/plugins/modules/items-planning-pn/modules/pairing/components/pairing-grid-table/pairing-grid-table.component.spec.ts | Adds Vitest mocks and model initialization. |
| eform-client/src/app/plugins/modules/items-planning-pn/modules/pairing/components/pairing-grid-table/pairing-grid-table.component.html | Indexes planning-name IDs. |
| eform-client/src/app/plugins/modules/items-planning-pn/modules/pairing/components/pairing-grid-page/pairing-grid-page.component.ts | Adds standalone page dependencies. |
| eform-client/src/app/plugins/modules/items-planning-pn/modules/pairing/components/pairing-grid-page/pairing-grid-page.component.spec.ts | Updates Vitest construction-test setup. |
| eform-client/src/app/plugins/modules/items-planning-pn/layouts/items-planning-pn-layout.component.ts | Imports the standalone router outlet. |
| eform-client/src/app/plugins/modules/items-planning-pn/items-planning-pn.module.ts | Simplifies imports around the standalone layout. |
| eform-client/playwright/e2e/plugins/items-planning-pn/ItemsPlanningPairingPage.ts | Matches indexed IDs in Playwright selectors. |
| eform-client/e2e/Page objects/ItemsPlanning/ItemsPlanningPairingPage.ts | Matches indexed IDs in WebdriverIO selectors. |
| Dockerfile | Enables Corepack and builds with Yarn. |
| .github/workflows/dotnet-core-pr.yml | Matches frontend target branches and adds unit tests. |
| .github/workflows/dotnet-core-master.yml | Adds branch-matched unit tests and Corepack. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves this plugin's Angular 21 line (
angular19) intomaster.masterhas not moved sinceangular19was created from it.angular19this was reviewed, merged and verified green against the frontend'sangular19.masteris now on Angular 21 as well (Angular 21: merge angular19 into master eform-angular-frontend#8161), so this PR's CI runs against it.🤖 Generated with Claude Code