You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Angular 21: standalone components, Vitest and angular19 CI - #2144
Part of the Angular 21 upgrade. The frontend's angular19 branch is now on Angular 21 with standalone components and Vitest (microting/eform-angular-frontend#8155).
CI: PR CI checks out the frontend (and any sibling plugins) at the branch the PR targets. Corepack is enabled before every yarn install, because the frontend's angular19 pins Yarn 4. The Dockerfile builds the frontend with yarn. Dead WDIO copy steps are removed.
Standalone: every component now imports exactly what its template uses. NgModule declarations are removed.
Fixes found on the way: planning tags render in a mat-chip-set. mat-chip-list no longer exists in Material, so the tags were already rendering broken. Repeated planning IDs are now indexed, with selectors updated. The tags dialog now gets its tags via setAvailableTags().
Tests: the scaffold specs are rewritten for Vitest (6 files, 7 tests), and a new angular-unit-test CI job runs them with ng test.
Verified locally with ng build against frontend angular19, together with the other migrated plugins. Code reviewed. Not yet clicked through in a browser.
PR CI checks out the frontend (and sibling plugins) at the branch the PR
targets instead of always stable. Corepack is enabled before every yarn
install, since the frontend's angular19 branch pins yarn@4; the Docker
build uses yarn for the frontend build as well. Dead WDIO config copies
are dropped (the frontend no longer has WDIO).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The new mat-chip-set contains plain mat-chip elements, which are intended for non-interactive content, but each tag still filters the table through (click). This does not provide keyboard activation, so keyboard users cannot activate these tag filters. Use native buttons or an interactive mat-chip-listbox/mat-chip-option implementation with an accessible label and a selection handler that preserves the filtering behavior; update the standalone imports as needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the Angular 21 upgrade. The frontend's
angular19branch is now on Angular 21 with standalone components and Vitest (microting/eform-angular-frontend#8155).yarn install, because the frontend'sangular19pins Yarn 4. The Dockerfile builds the frontend with yarn. Dead WDIO copy steps are removed.declarationsare removed.mat-chip-set.mat-chip-listno longer exists in Material, so the tags were already rendering broken. Repeated planning IDs are now indexed, with selectors updated. The tags dialog now gets its tags viasetAvailableTags().angular-unit-testCI job runs them withng test.Verified locally with
ng buildagainst frontendangular19, together with the other migrated plugins. Code reviewed. Not yet clicked through in a browser.🤖 Generated with Claude Code