Merge stable back into master - #8066
Merged
Merged
Conversation
…t and review findings (#8065) Time-planning planning grid (.mtx-grid.time-dashboard): the plugin boxes every header cell and its status classes force !important borders. The header now has only the tint and the bottom line; body day dividers stay but in the row-separator colour, and none against the frame's edges. Compliance report "Rapport" grid (and every mtx-grid): - box-sizing: border-box, so width 100% plus the 1px frame no longer overflows and an overflow: hidden parent stops clipping the right edge. - No mtx divider after left-pinned columns (time-planning keeps its pale one). - Pinned header cells keep the --bg tint against plugin paints. - Thin themed scrollbar on grid scrollers. Review follow-ups (post-merge review of #8061 and Copilot's comments): - Sub-header and px-3 gutter rules scoped to the content card, so the simple-layout connection-setup page keeps its padding. - Backend-configuration case page: its routed div.p-4 root no longer doubles the 24px gutter. - Hand-written mat-mdc-table rows lose the separator under the last row. - Radius token and :is() grouping; icon-button comment made accurate. eForm Classic is unchanged: every rule is scoped to body.theme-workspace. Playwright (shard g): checks the last-row edge, grid box-sizing, the pinned header tint against an injected plugin paint, the full-bleed content-card exception, time-planning dividers and pinned-left dividers. Claude-Session: https://claude.ai/code/session_01HfLyiGF7BQTRixiUfSuXxD Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review comments were identified, and the supplied assessments support approval.
Pull request overview
This pull request syncs stable’s eForm new-design styling updates and regression tests into master.
Changes:
- Refines workspace table sizing, borders, scrolling, pinned columns, and grid styling.
- Updates content-card and routed-page spacing rules.
- Adds Playwright regression coverage.
File summaries
| File | Summary |
|---|---|
eform-client/src/scss/components/_workspace-utilities.scss |
Updates table radius tokens and documentation. |
eform-client/src/scss/components/_workspace-patterns.scss |
Refines content-card gutters and route-specific padding. |
eform-client/src/scss/components/_workspace-mat-overrides.scss |
Adds grid, scrollbar, divider, and table styling. |
eform-client/playwright/e2e/Tests/g/application-settings.theme-new-design.spec.ts |
Adds regression tests for the new design. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync
stableback intomasterafter the "eForm new design" table work (eform-angular-frontend #8065, eform-backendconfiguration-plugin #1267).🤖 Generated with Claude Code
https://claude.ai/code/session_01HfLyiGF7BQTRixiUfSuXxD