Fix Angular 21 upgrade issues: change detection, test mocks, and modal dropdowns - #7487

Open

renemadsen with Copilot wants to merge 34 commits into

angular19from

copilot/fix-expression-change-error

Commits on Jan 29, 2026

Initial plan
Copilot
committed
e3b41be
Add ChangeDetectorRef to fix ExpressionChangedAfterItHasBeenCheckedError

Copilot
and
renemadsen
committed
51da0bf
Use markForCheck instead of detectChanges for better change detection

Copilot
and
renemadsen
committed
a73e7f2
Add clarifying comment to trigger CI pipeline

Copilot
and
renemadsen
committed
04dd2f4
Fix multiple ExpressionChangedAfterItHasBeenCheckedError issues across components

Copilot
and
renemadsen
committed
ba1c583
Use detectChanges instead of markForCheck for default change detection strategy

Copilot
and
renemadsen
committed
a2f1db3
Fix ExpressionChangedAfterItHasBeenCheckedError in 5 additional components

Copilot
and
renemadsen
committed
822e55a
Remove unnecessary detectChanges call from synchronous else branch

Copilot
and
renemadsen
committed
9312d14
Fix FoldersComponent unit test by adding ChangeDetectorRef mock

Copilot
and
renemadsen
committed
b4664bd
Fix TranslateService mock to return proper observables in FoldersComponent test

Copilot
and
renemadsen
committed
364b07b
Add missing getParsedResult and getCurrentLang methods to TranslateService mock

Copilot
and
renemadsen
committed
e36d573
Remove detectChanges() calls from EformsPageComponent to fix Angular 21 tags API issue

Copilot
and
renemadsen
committed
135f325
Use markForCheck() instead of detectChanges() for Angular 21 compatibility

Copilot
and
renemadsen
committed
c5c4a1e
Fix mtx-select dropdownPosition attribute for Angular 21 compatibility

Copilot
and
renemadsen
committed
df76929
Fix all mtx-select dropdownPosition attributes across codebase for Angular 21

Copilot
and
renemadsen
committed
50db9eb
Fix TranslateService mocks in all unit tests for Angular 21 compatibility

Copilot
and
renemadsen
committed
1591db5
Fix TranslatePipe subscription errors by using EventEmitter for event properties

Copilot
and
renemadsen
committed
3105cfa
Add complete TranslateService interface to all test mocks

Copilot
and
renemadsen
committed
e1c0271
Fix mtx-select dropdown z-index issues in modals for Angular 21

Copilot
and
renemadsen
committed
677a689
Fix Angular 21 modal/dialog positioning and rendering issues

Copilot
and
renemadsen
committed
98754d8
Fix modal backdrop to be semi-transparent instead of completely opaque

Copilot
and
renemadsen
committed
408d1a0
Revert appendTo="body" additions from modal components

Copilot
and
renemadsen
committed
0fbca24
Fix Angular 21 CDK overlay structure with nested backdrop

Copilot
and
renemadsen
committed
ec0f939
Fix popover top layer blocking dropdowns by using maximum z-index

Copilot
and
renemadsen
committed
fa5dc4a
Revert all mtx-select and modal CSS/dialog fixes that broke tooltips

Copilot
and
renemadsen
committed
8106a52
Restore missing appendTo="body" attributes in modal dialog mtx-select components

Copilot
and
renemadsen
committed
9c1cd41
Fix appendTo syntax to use property binding per mtx-select documentation

Copilot
and
renemadsen
committed
ebb6efe
Remove appendTo attribute to use default behavior with Angular 21 popover structure

Copilot
and
renemadsen
committed
49e54f6
Implement custom OverlayContainer for Angular 21 popover top layer compatibility

Copilot
and
renemadsen
committed
1176bc4
Add automatic overlay container management in AppComponent for all dialogs

Copilot
and
renemadsen
committed
aa112fe
Apply proper Angular 21 solution: use appendTo='.cdk-overlay-pane' for modal dropdowns

Copilot
and
renemadsen
committed
4c5f0c5
Remove appendTo attribute to fix dropdown positioning in Angular 21 modals

Copilot
and
renemadsen
committed
4ec6ffa

Commits on Jan 30, 2026

Restore appendTo cdk-overlay-pane with CSS fix for correct dropdown positioning

Copilot
and
renemadsen
committed
af263eb
Remove position:fixed CSS hack per ng-select #2738 - use pure appendTo solution

Copilot
and
renemadsen
committed
696f758

Navigation Menu

Fix Angular 21 upgrade issues: change detection, test mocks, and modal dropdowns - #7487

Fix Angular 21 upgrade issues: change detection, test mocks, and modal dropdowns#7487
renemadsen with Copilot wants to merge 34 commits into
angular19from
copilot/fix-expression-change-error

Commits on Jan 29, 2026

Initial plan

Add ChangeDetectorRef to fix ExpressionChangedAfterItHasBeenCheckedError

Use markForCheck instead of detectChanges for better change detection

Add clarifying comment to trigger CI pipeline

Fix multiple ExpressionChangedAfterItHasBeenCheckedError issues across components

Use detectChanges instead of markForCheck for default change detection strategy

Fix ExpressionChangedAfterItHasBeenCheckedError in 5 additional components

Remove unnecessary detectChanges call from synchronous else branch

Fix FoldersComponent unit test by adding ChangeDetectorRef mock

Fix TranslateService mock to return proper observables in FoldersComponent test

Add missing getParsedResult and getCurrentLang methods to TranslateService mock

Remove detectChanges() calls from EformsPageComponent to fix Angular 21 tags API issue

Use markForCheck() instead of detectChanges() for Angular 21 compatibility

Fix mtx-select dropdownPosition attribute for Angular 21 compatibility

Fix all mtx-select dropdownPosition attributes across codebase for Angular 21

Fix TranslateService mocks in all unit tests for Angular 21 compatibility

Fix TranslatePipe subscription errors by using EventEmitter for event properties

Add complete TranslateService interface to all test mocks

Fix mtx-select dropdown z-index issues in modals for Angular 21

Fix Angular 21 modal/dialog positioning and rendering issues

Fix modal backdrop to be semi-transparent instead of completely opaque

Revert appendTo="body" additions from modal components

Fix Angular 21 CDK overlay structure with nested backdrop

Fix popover top layer blocking dropdowns by using maximum z-index

Revert all mtx-select and modal CSS/dialog fixes that broke tooltips

Restore missing appendTo="body" attributes in modal dialog mtx-select components

Fix appendTo syntax to use property binding per mtx-select documentation

Remove appendTo attribute to use default behavior with Angular 21 popover structure

Implement custom OverlayContainer for Angular 21 popover top layer compatibility

Add automatic overlay container management in AppComponent for all dialogs

Apply proper Angular 21 solution: use appendTo='.cdk-overlay-pane' for modal dropdowns

Remove appendTo attribute to fix dropdown positioning in Angular 21 modals

Commits on Jan 30, 2026

Restore appendTo cdk-overlay-pane with CSS fix for correct dropdown positioning

Remove position:fixed CSS hack per ng-select #2738 - use pure appendTo solution