Skip to content

fix: expand ~ in python.venvFolders entries #1828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Alexandre Kohler (kwy404) wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −3
Open

fix: expand ~ in python.venvFolders entries #1828

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/managers/common/nativePythonFinder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1544,6 +1544,9 @@ function getPythonSettingAndUntildify<T>(name: string, scope?: Uri): T | undefin
if (typeof value === 'string') {
return value ? (untildify(value as string) as unknown as T) : undefined;
}
if (Array.isArray(value)) {
return untildifyArray(value) as unknown as T;
}
return value;
}

Expand Down
4 changes: 1 addition & 3 deletions src/test/managers/common/nativePythonFinder.getAllExtraSearchPaths.unit.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,10 +206,8 @@ suite('getAllExtraSearchPaths Integration Tests', () => {

test('Legacy paths with untildify support', async () => {
// Mock → Legacy paths with tilde expansion
// Note: getPythonSettingAndUntildify only untildifies strings, not array items
// So we return the venvPath with tilde (will be untildified) and venvFolders pre-expanded
pythonConfig.get.withArgs('venvPath').returns('~/virtualenvs');
pythonConfig.get.withArgs('venvFolders').returns(['/home/user/conda/envs']); // Pre-expanded
pythonConfig.get.withArgs('venvFolders').returns(['~/conda/envs']);
envConfig.inspect.withArgs('globalSearchPaths').returns({ globalValue: [] });
envConfig.inspect.withArgs('workspaceSearchPaths').returns({});

Expand Down