terminal: avoid writing activation mode during lookup - #1826
Merged
Eleanor Boyd (eleanorjboyd) merged 1 commit intoSep 25, 2026
Merged
Eleanor Boyd (eleanorjboyd) merged 1 commit into
Eleanor Boyd (eleanorjboyd) merged 1 commit into
Conversation
Keep the legacy Python activation setting as an effective fallback without persisting an override. Cover legacy setting changes and explicit Python Environments precedence. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Raymond Zhao (rzhao271)
approved these changes
Sep 25, 2026
Eleanor Boyd (eleanorjboyd)
added
the
bug
Eleanor Boyd (eleanorjboyd)
merged commit Sep 25, 2026
87f4dea
into
microsoft:main
18 of 19 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
offwhen the legacypython.terminal.activateEnvironmentsetting is false, without writing a persistentpython-envs.terminal.autoActivationTypeoverride from a getter.The setting is machine-scoped, so the previous implicit workspace-target write likely failed rather than persisting for users; this still removes an unnecessary, unawaited write attempt. This PR is independent of #1823 and contains only the getter and related tests.