Fix path-only Python project manager defaults - #1667
Eleanor Boyd (eleanorjboyd) merged 3 commits into
Conversation
Assisted-by: OpenAI Codex
d7702f7 to
8a98b2f
Compare
|
@microsoft-github-policy-service agree |
|
🔒 Automated review in progress — Heejae Chang (@heejaechang) is auto-reviewing this PR. |
| test('uses default managers when a pythonProjects entry only specifies path', () => { | ||
| sinon.stub(workspaceApis, 'getConfiguration').returns(createPathOnlyProjectConfig()); | ||
| sinon.stub(workspaceApis, 'getWorkspaceFolder').returns(workspaceFolder); | ||
|
|
There was a problem hiding this comment.
Info · Optional note
The fallback test covers omitted manager values but not explicitly empty strings, despite the PR claiming both cases. Consider adding empty-string assertions to preserve that behavior explicitly.
[verified]
Heejae Chang (heejaechang)
left a comment
There was a problem hiding this comment.
Approved via Review Center.
|
Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified. |
|
Thanks Atomie CHEN (@atomiechen) ! Sorry this has become stale, if you update it for the merge conflict I can approve and we can get this merged! |
Resolve the project settings type move and cover empty manager values. AI-Assisted-By: OpenAI Codex
|
Eleanor Boyd (@eleanorjboyd) The merge conflict is resolved and the PR is ready for another look when you have time. Thanks for offering to review it. Updated this PR with the latest upstream Local validation: AI disclosure: OpenAI Codex assisted with the conflict resolution and the additional regression test. The merge commit records this with an |
Eleanor Boyd (eleanorjboyd)
left a comment
There was a problem hiding this comment.
🤖 Re-reviewed the updated PR. The manager fields are now optional in the project settings type, both lookup helpers fall back correctly for omitted or empty values, and the added unit tests cover both cases. I found no blocking issue in the changes. CI is still pending; this approval does not replace a green run.
b893232
into
microsoft:main
Summary
Fixes #1666.
Path-only entries are valid according to the
python-envs.pythonProjectssetting schema:{ "python-envs.pythonProjects": [ { "path": "backend" } ] }However, the manager-setting helpers called
.lengthon the omittedenvManagerandpackageManagerproperties. This caused repeatedTypeErrorfailures during post-initialization telemetry and environment lookup.Fix
PythonProjectSettings.envManagerand.packageManageroptional so the internal type matches the contributed JSON schema.Validation
--user-data-dir/--extensions-dirprofile.TypeErroror post-initialization failure.npm run compile-testsnpm run lintnpm run unittest— 1,429 passing, 6 pendingAI disclosure: Prepared with assistance from OpenAI Codex.