Add "Sort Imports" & "Remove Unused Imports" commands to VS Code extension by Copilot · Pull Request #3305 · microsoft/typescript-go

Copilot · 2026-03-31T23:13:36Z

The LSP server already supports source.sortImports and source.removeUnusedImports code action kinds, but the extension never registered corresponding command handlers.

_extension/src/session.ts: Register runtime command handlers for the main TypeScript extension's command IDs (typescript.sortImports, javascript.sortImports, typescript.removeUnusedImports, javascript.removeUnusedImports) that delegate to VS Code's built-in editor.action.sourceAction
_extension/src/session.ts: Reorder Session.dispose() to unregister commands before yielding to the event loop, preventing "command already exists" race conditions when the built-in TypeScript extension reactivates

The commands are registered only at runtime (not declared in package.json) to avoid "command already exists" conflicts when useTsgo is off and the main TypeScript extension is also loaded. By reusing the main extension's command IDs, the native preview extension seamlessly takes over those commands when tsgo is active. Disposal is ordered so that command registrations are synchronously removed before any await yields control, ensuring the built-in extension can cleanly re-register them when the native preview extension is disabled. The existing "Organize Imports" command is already wired up through the language client and does not need a separate entry.

…s to VS Code extension Agent-Logs-Url: https://github.com/microsoft/typescript-go/sessions/045863e2-6044-4847-8156-7e044e313d98 Co-authored-by: DanielRosenwasser <972891+DanielRosenwasser@users.noreply.github.com>

DanielRosenwasser · 2026-03-31T23:26:56Z

+
+        this.disposables.push(vscode.commands.registerCommand("typescript.native-preview.organizeImports", async () => {
+            await vscode.commands.executeCommand("editor.action.organizeImports");
+        }));


We don't need this, it's already wired up to the language client.

@copilot fix

Removed in 0545e93.

…uage client Agent-Logs-Url: https://github.com/microsoft/typescript-go/sessions/413800a1-0e85-4c97-bf25-4df34fdfea1c Co-authored-by: DanielRosenwasser <972891+DanielRosenwasser@users.noreply.github.com>

Copilot

Pull request overview

Adds explicit command palette entries in the VS Code “TypeScript (Native Preview)” extension for actions the LSP server already supports (source.sortImports and source.removeUnusedImports), by delegating to VS Code’s built-in editor.action.sourceAction.

Changes:

Contribute two new commands (typescript.native-preview.sortImports, typescript.native-preview.removeUnusedImports) gated on typescript.native-preview.serverRunning.
Register command handlers that invoke editor.action.sourceAction with the corresponding kind (source.sortImports / source.removeUnusedImports).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
`_extension/src/session.ts`	Registers two new commands and delegates execution to VS Code source actions for sort/remove-unused-imports.
`_extension/package.json`	Declares the two new commands with enablement tied to the native preview server running.

jakebailey · 2026-03-31T23:43:45Z

+                "command": "typescript.native-preview.sortImports",
+                "title": "Sort Imports",
+                "enablement": "typescript.native-preview.serverRunning",
+                "category": "TypeScript Native Preview"
+            },
+            {
+                "command": "typescript.native-preview.removeUnusedImports",
+                "title": "Remove Unused Imports",
+                "enablement": "typescript.native-preview.serverRunning",
+                "category": "TypeScript Native Preview"
            }


This is going to be awkward because even though tsgo is enabled, the main package's is still declared:

Could we just register the command that the main extension is expecting? They shouldn't load when we are loaded and so on, so I think it might be possible.

@copilot give it a try. Also format when you're done.

Updated in 4c4a395 to register the same command IDs as the main extension: typescript.sortImports, javascript.sortImports, typescript.removeUnusedImports, and javascript.removeUnusedImports. Also matched apply: 'first' to be consistent with the main extension's behavior, and ran formatting.

Just tested it. If you do that while useTsgo is off, you weirdly get

Activating extension 'TypeScriptTeam.native-preview' failed: command 'typescript.sortImports' already exists.

I think the main extension should just be updated.

Do that @copilot

Removed the command declarations from package.json in 67ea746. The commands are now only registered at runtime in session.ts, so there's no conflict with the main extension's declarations when useTsgo is off.

If you disable this extension, the built-in extension will have issues:

rejected promise not handled within 1 second: Error: command 'typescript.sortImports' already exists

Seems like the command is not properly being unregistered.

@copilot fix.

Fixed in 87a11ca. The issue was that Session.dispose() was awaiting two setContext calls before disposing the command registrations. Those awaits yield control to the event loop, giving VS Code a chance to activate the built-in extension (which tries to register the same commands). Reordered to dispose registrations first — the d.dispose() calls in .map() run synchronously before any await yields.

…palette entries Agent-Logs-Url: https://github.com/microsoft/typescript-go/sessions/b3fccc6c-5163-4d72-8e28-b67bfc857ff2 Co-authored-by: DanielRosenwasser <972891+DanielRosenwasser@users.noreply.github.com>

DanielRosenwasser · 2026-04-01T00:42:51Z

+
+        for (const command of ["typescript.sortImports", "javascript.sortImports"]) {
+            this.disposables.push(vscode.commands.registerCommand(command, async () => {
+                await vscode.commands.executeCommand("editor.action.sourceAction", {


I don't think you need to await, you can just make this non-async and return or fire-and-forget).

Fixed in 67ea746 — handlers now just return the executeCommand call (non-async, fire-and-forget).

…sync Agent-Logs-Url: https://github.com/microsoft/typescript-go/sessions/7e5f78a1-e55d-424f-b346-df40585a513e Co-authored-by: DanielRosenwasser <972891+DanielRosenwasser@users.noreply.github.com>

…nt loop Agent-Logs-Url: https://github.com/microsoft/typescript-go/sessions/5fea471c-8900-4781-a94f-2c1368620df9 Co-authored-by: DanielRosenwasser <972891+DanielRosenwasser@users.noreply.github.com>

azure-pipelines · 2026-04-15T22:26:59Z

Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions.

jakebailey · 2026-04-16T23:27:03Z

+        // Dispose registrations first so that commands (e.g. typescript.sortImports)
+        // are synchronously unregistered before yielding to the event loop. This
+        // avoids "command already exists" errors when the built-in TS extension
+        // activates after this extension is disabled.
+        await Promise.all(this.disposables.map(d => d.dispose()));


I don't really understand how moving this upward achieves this goal.

Initial plan

fa3f5dd

Copilot AI assigned Copilot and DanielRosenwasser Mar 31, 2026

Copilot started work on behalf of DanielRosenwasser March 31, 2026 23:13 View session

Copilot AI linked an issue Mar 31, 2026 that may be closed by this pull request

"Sort Imports" & "Remove Unused Imports" commands are missing #1724

Open

Copilot AI changed the title ~~[WIP] Add commands for sorting and removing unused imports~~ Add "Sort Imports" & "Remove Unused Imports" commands to VS Code extension Mar 31, 2026

Copilot AI requested a review from DanielRosenwasser March 31, 2026 23:20

Copilot finished work on behalf of DanielRosenwasser March 31, 2026 23:20

DanielRosenwasser reviewed Mar 31, 2026

View reviewed changes

Copilot started work on behalf of DanielRosenwasser March 31, 2026 23:27 View session

Remove unnecessary organizeImports command; already wired up via lang…

0545e93

…uage client Agent-Logs-Url: https://github.com/microsoft/typescript-go/sessions/413800a1-0e85-4c97-bf25-4df34fdfea1c Co-authored-by: DanielRosenwasser <972891+DanielRosenwasser@users.noreply.github.com>

Copilot finished work on behalf of DanielRosenwasser March 31, 2026 23:31

Copilot AI requested a review from DanielRosenwasser March 31, 2026 23:31

DanielRosenwasser marked this pull request as ready for review March 31, 2026 23:39

DanielRosenwasser requested review from Copilot, iisaduan and jakebailey March 31, 2026 23:39

Copilot started reviewing on behalf of DanielRosenwasser March 31, 2026 23:41 View session

Copilot AI reviewed Mar 31, 2026

View reviewed changes

jakebailey reviewed Mar 31, 2026

View reviewed changes

Copilot started work on behalf of DanielRosenwasser March 31, 2026 23:48 View session

Use same command IDs as main TypeScript extension to avoid duplicate …

4c4a395

…palette entries Agent-Logs-Url: https://github.com/microsoft/typescript-go/sessions/b3fccc6c-5163-4d72-8e28-b67bfc857ff2 Co-authored-by: DanielRosenwasser <972891+DanielRosenwasser@users.noreply.github.com>

Copilot AI changed the title ~~Add "Sort Imports" & "Remove Unused Imports" commands to VS Code extension~~ Add "Sort Imports" & "Remove Unused Imports" commands to VS Code extension Mar 31, 2026

Copilot finished work on behalf of DanielRosenwasser March 31, 2026 23:56

DanielRosenwasser reviewed Apr 1, 2026

View reviewed changes

Copilot started work on behalf of DanielRosenwasser April 6, 2026 18:05 View session

Remove command declarations from package.json and make handlers non-a…

67ea746

…sync Agent-Logs-Url: https://github.com/microsoft/typescript-go/sessions/7e5f78a1-e55d-424f-b346-df40585a513e Co-authored-by: DanielRosenwasser <972891+DanielRosenwasser@users.noreply.github.com>

Copilot finished work on behalf of DanielRosenwasser April 6, 2026 18:10

Copilot AI requested a review from DanielRosenwasser April 6, 2026 18:10

jakebailey changed the title ~~Add "Sort Imports" & "Remove Unused Imports" commands to VS Code extension~~ Add "Sort Imports" and "Remove Unused Imports" commands to VS Code extension Apr 6, 2026

Merge branch 'main' into copilot/add-sort-and-remove-unused-imports

996160f

Copilot started work on behalf of DanielRosenwasser April 15, 2026 22:18 View session

Fix command disposal race: unregister commands before yielding to eve…

87a11ca

…nt loop Agent-Logs-Url: https://github.com/microsoft/typescript-go/sessions/5fea471c-8900-4781-a94f-2c1368620df9 Co-authored-by: DanielRosenwasser <972891+DanielRosenwasser@users.noreply.github.com>

Copilot AI changed the title ~~Add "Sort Imports" and "Remove Unused Imports" commands to VS Code extension~~ Add "Sort Imports" & "Remove Unused Imports" commands to VS Code extension Apr 15, 2026

Copilot finished work on behalf of DanielRosenwasser April 15, 2026 22:28

jakebailey mentioned this pull request Apr 16, 2026

Organize imports for TypeScript and JavaScript #1770

Closed

jakebailey reviewed Apr 16, 2026

View reviewed changes

RyanCavanaugh added this to the TypeScript 7.0 RC milestone Apr 17, 2026

Conversation

Copilot AI commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

azure-pipelines bot commented Apr 15, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Copilot AI commented Mar 31, 2026 •

edited

Loading