Repository navigation
Handle crashing benchmarks better - #167
Merged
Merged
Conversation
tsgo's LSP mode does not accept --disableAutomaticTypingAcquisition and exits immediately with a usage error, so lsp-startup has been timing flag parsing rather than server startup. It also makes the scenario look like a crash once startup failures are detected.
If tsserver or the LSP server dies while a request is pending, the response promise never settles. Node then exits with status 0 once the event loop drains, so a crashed server is recorded as a successful run with partial or missing timings.
A scenario that crashes the compiler under test has no samples, and an empty measurement currently makes the comparison step throw. The whole run then fails, and the PR gets a generic failure comment that hides the results of every other scenario. Record the failure explicitly so that results can still be merged, uploaded and compared. Reports show the scenario as failed in place of its metrics, so the crash is visible next to the other results.
When the compiler under test crashes, the benchmark should still finish and report, with the crash called out, rather than failing the whole pipeline or silently timing a broken run. Stop measuring a scenario at its first failed iteration, since later iterations of a crashing build only add time and noise. tsc exits nonzero for ordinary type errors, so a tsc run counts as failed only if it never reported its timing diagnostics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.