Repository navigation
fix(test-adapter): run settings parsing, launch options copy, launch options for remote browsers - #3455
Merged
Conversation
- A JSON value keeps the apostrophes in its strings. The shorthand with single quotes still works. - An element that is not supported is skipped whole, so its children are not read as settings. - An enum value is accepted by its C# name in any case, next to the documented value. - PlaywrightSettingsXml.Retries was read by nothing and is removed. PlaywrightSettingsXml.Headless was never read from the run settings and is obsolete in favor of LaunchOptions.Headless. References: microsoft#3431
PlaywrightSettingsProvider.LaunchOptions returned the object parsed from the run settings, so a test class that changed the options it got changed them for every later caller. HEADED=1 was written into that object as well. Fixes: microsoft#3425
… a remote browser The x-playwright-launch-options header was built from the run settings only, so a LaunchOptionsAsync override was dropped when connecting to a server. A test class that set the header itself in ConnectOptionsAsync got an ArgumentException for the duplicate key; its header is now kept. Fixes: microsoft#3424
Pavel Feldman (pavelfeldman)
approved these changes
Nov 10, 2026
Pavel Feldman (pavelfeldman)
merged commit Nov 10, 2026
be92216
into
microsoft:main
14 of 16 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PlaywrightSettingsXml.Retrieswas read by nothing and is removed, with a compatibility suppression.PlaywrightSettingsXml.Headlesswas never read from the run settings and is now obsolete in favor ofLaunchOptions.Headless.PlaywrightSettingsProvider.LaunchOptionsreturns a copy, so a test class that changes the options it got does not change them for the next one.x-playwright-launch-optionsheader carries theLaunchOptionsAsync()result of the test class, and a header that the class set itself is kept instead of throwing.Fixes #3425
Fixes #3424
Fixes #3431