Repository navigation
fix: transport read buffer, WebSocket base URL scheme, empty PLAYWRIGHT_NODEJS_PATH, Locator debugger display - #3454
Merged
Conversation
…ce per connection The reader took 1 KB per read, so a 10 MB message took about 10,000 reads, and every message sent or received looked up the DEBUG environment variable. Fixes: microsoft#3437
…PLAYWRIGHT_NODEJS_PATH as not set - URLMatch.ToWebSocketBaseURL replaced every "http://" in the base URL, also one in its path or query. - An empty PLAYWRIGHT_NODEJS_PATH, as CI templates often declare it, made the driver fail to start instead of using the bundled Node.js. References: microsoft#3433
…String() Locator.ToString() waits for the driver. While a debugger evaluates it, the other threads are frozen, so hovering a locator ended in "Function evaluation timed out". The debugger now shows the selector without calling it. References: microsoft#3427
Pavel Feldman (pavelfeldman)
approved these changes
Nov 10, 2026
Pavel Feldman (pavelfeldman)
merged commit Nov 10, 2026
ed5abf0
into
microsoft:main
15 of 16 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DEBUGis read once per connection instead of for every message.URLMatch.ToWebSocketBaseURLreplaces only the scheme, not everyhttp://in the base URL.PLAYWRIGHT_NODEJS_PATHcounts as not set, so the bundled Node.js is used.Locatorhas aDebuggerDisplay, so a debugger shows the selector and does not callToString(), which waits for the driver.Fixes #3437
Fixes #3433
Fixes #3427