Repository navigation
chore: build the driver and the generated API from a pinned microsoft/playwright commit - #3420
Merged
Conversation
…/playwright commit DriverVersion in src/Common/Version.props holds a microsoft/playwright commit. ./build.sh --build-driver clones microsoft/playwright into .upstream/ (gitignored), checks out that commit and builds the driver from it. ./build.sh --generate generates the API and the transport channels from it. Nothing is downloaded from npm. - ./build.sh --roll <ref> takes a branch, a tag or a commit, and ./build.sh --changes lists the upstream commits to port. - CI and the Azure pipelines build the driver from .upstream/. The code style job also checks that the generated files are up to date. - The harness tests launch the browser server from the built driver, so @playwright/test no longer follows the driver version. - CONTRIBUTING.md, ROLLING.md, CLAUDE.md and the roll, triage and release skills follow these steps. - The starting commit is 5ccfbd85, the tip of release-1.65.
Yury Semikhatsky (yury-s)
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DriverVersioninsrc/Common/Version.propsis amicrosoft/playwrightcommit../build.sh --build-driverclones it into.upstream/(gitignored) and builds the driver from it;./build.sh --generategenerates the API and the transport channels from it. Nothing is downloaded from npm../build.sh --roll <ref>takes a branch, a tag or a commit, and./build.sh --changeslists the upstream commits to port..upstream/. The code style job also checks that the generated files are up to date.@playwright/testno longer follows the driver version.5ccfbd85, the tip ofrelease-1.65.Same approach as microsoft/playwright-python#3285.