Repository navigation
fix(frame): do not lose a navigation or load state that lands while a wait subscribes - #3405
Closed
Simon Cropp (SimonCropp) wants to merge 1 commit into
Closed
Simon Cropp (SimonCropp) wants to merge 1 commit into
Simon Cropp (SimonCropp) wants to merge 1 commit into
Conversation
… wait subscribes Events arrive on the connection's thread while a wait checks the frame's URL or load states and then subscribes on the caller's, so one landing in between was recorded but never heard, and the wait ran out its timeout. The frame now updates its state and takes the handlers to raise under one lock, and the waits check and subscribe under it. Fixes: microsoft#3364
Collaborator
|
Closing in favor of #3453. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FrameupdatesUrl/_loadStatesand takes theNavigated/LoadStatehandlers under one lock;WaitForLoadStateAsync,WaitForURLAsyncand the post-navigation load-state wait check and subscribe under the same lock, so an event landing between check and subscribe is no longer lost.WaitForURLAsyncon an already-matching URL now goes through the navigation wait, which checks the URL where it subscribes (the URL predicate runs outside the lock).Fixes #3364
Also addresses #3399