Repository navigation
test(threading): pin the pitfalls of the client threading model - #3386
Closed
Yury Semikhatsky (yury-s) wants to merge 1 commit into
Closed
Yury Semikhatsky (yury-s) wants to merge 1 commit into
Yury Semikhatsky (yury-s) wants to merge 1 commit into
Conversation
Six short tests that assert what the threading model does today: the ordering guarantee for events that precede a reply, and the pitfalls that follow from event-driven waits and event handlers running on the reader thread.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Waiter) resume inline on the reader thread, soPage.Loadhas not fired yet afterawait WaitForLoadStateAsync(), and a synchronous wait there stalls the connection; the same for event handlers; a throwing handler closes the whole connection.Passes on chromium, firefox and webkit, three runs each.