setup.py: respect onnxruntime env variables#1073
Open
AlekseiNikiforovIBM wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds support for configuring ONNX Runtime package source/version via environment variables when building the CMake extension.
Changes:
- Add
OCOS_ONNXRUNTIME_PKG_URIas an alternative toself.ort_pkg_dirfor supplying the ONNX Runtime package location. - Add
OCOS_ONNXRUNTIME_VERSIONCMake definition when provided via environment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+208
to
+212
| elif os.environ.get('OCOS_ONNXRUNTIME_PKG_URI'): | ||
| cmake_args += ['-DOCOS_ONNXRUNTIME_PKG_URI=' + os.environ.get('OCOS_ONNXRUNTIME_PKG_URI')] | ||
|
|
||
| if os.environ.get('OCOS_ONNXRUNTIME_VERSION'): | ||
| cmake_args += ['-DOCOS_ONNXRUNTIME_VERSION=' + os.environ.get('OCOS_ONNXRUNTIME_VERSION')] |
Comment on lines
+209
to
+212
| cmake_args += ['-DOCOS_ONNXRUNTIME_PKG_URI=' + os.environ.get('OCOS_ONNXRUNTIME_PKG_URI')] | ||
|
|
||
| if os.environ.get('OCOS_ONNXRUNTIME_VERSION'): | ||
| cmake_args += ['-DOCOS_ONNXRUNTIME_VERSION=' + os.environ.get('OCOS_ONNXRUNTIME_VERSION')] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setup.py: respect OCOS_ONNXRUNTIME_PKG_URI and OCOS_ONNXRUNTIME_VERSION env variables
With this change it is possible to build onnxruntime-extensions using setup.py with custom-built onnxruntime.