Skip to content

scripts: let the runtime adapter's suite run on KVM on a host that also has /dev/mshv #1019

Open

Description

The runtime adapter's suite command (command_test_runtime_adapter in scripts/nvx_tools/runtime_adapter_tests.py) checks its backend with the shared validate_openvmm_test_backend (scripts/nvx_tools/ci.py), which refuses kvm whenever /dev/mshv exists, because OpenVMM would otherwise select MSHV on its own. The runtime adapter names the hypervisor explicitly, though: its tests pass --hypervisor from NVX_HYPERVISOR (guest_options in tests/runtime-adapter/tests/common/mod.rs, and tests/runtime-adapter/src/layered.rs). So on a host that exposes both /dev/kvm and /dev/mshv, the suite refuses KVM although it could run on it.

To fix: separate the auto-selection restriction from the OS and device-access checks, and have the runtime adapter's command use only the latter.

Found in #963 (a review thread on scripts/nvx_tools/runtime_adapter_tests.py, line 275, still open at merge). Related to #833.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions